[
https://issues.apache.org/jira/browse/IMPALA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926341#comment-17926341
]
Surya Hebbar commented on IMPALA-13751:
---------------------------------------
Thanks [~laszlog]. The identified patch is correct. I went through all the
builds.
The reason for failure was the following.
* For the 'CompleteEvents' test, we try simulating the formation of a complete
event sequence, without any missing events. This is the ideal case, so events
are validated based on this idealness.
* For the 'MissingEvents' test, we try simulating the formation of an
incomplete event sequence, with missing events. We try to ensure these missing
events are really missing, and recorded events are really there.
These tests run fine, when environment for testing is ideal, when all events
intended for recording are really recorded.
The new changes and related test code is correct.
We need to cover the possibility of missing events for the testing environment
itself, which could be another source. I will post a fix to cover this
possibility of missing events.
> runtime-profile-test fails, then crashes since IMPALA-13304
> -----------------------------------------------------------
>
> Key: IMPALA-13751
> URL: https://issues.apache.org/jira/browse/IMPALA-13751
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 4.6.0
> Reporter: Laszlo Gaal
> Assignee: Surya Hebbar
> Priority: Blocker
> Labels: broken-build
>
> I have picked IMPALA-13304: Include aggregate instance-level metrics in JSON
> profile as the culprit for two reasons: it seems to have touched relevant
> parts, and downstream post-commit builds have consistently failed with this
> problem since it was merged. Also, we had several passing builds right before
> IMPALA-13304 was merged (these are all simple core-mode test runs).
> Downstream test failures have been observed on CentOS 7 and Red Hat 8 runs,
> so I wonder if there is a hidden platform dependency in the failing code.
> Failure logs reported from BE_TESTs:
> {code}
> ----------] 4 tests from AggregatedEventSequenceToJsonTest
> [ RUN ]
> AggregatedEventSequenceToJsonTest.CompleteEvents_GroupedAndAggregatedCase
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/be/src/util/runtime-profile-test.cc:2222:
> Failure
> Expected equality of these values:
> inst_count_cur
> Which is: 39
> NUM_PROFILES
> Which is: 40
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/be/src/util/runtime-profile-test.cc:2222:
> Failure
> Expected equality of these values:
> inst_count_cur
> Which is: 9
> NUM_PROFILES
> Which is: 10
> [ FAILED ]
> AggregatedEventSequenceToJsonTest.CompleteEvents_GroupedAndAggregatedCase
> (1819 ms)
> [ RUN ]
> AggregatedEventSequenceToJsonTest.CompleteEvents_GroupedAndUnggregatedCase
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/be/src/util/runtime-profile-test.cc:2104:
> Failure
> Expected equality of these values:
> ts_list_cur_json.Size()
> Which is: 18
> ts_list_prev_json.Size()
> Which is: 17
> unifiedbetests:
> /data/jenkins/workspace/impala-asf-master-core/Impala-Toolchain/toolchain-packages-gcc10.4.0/rapidjson-1.1.0-p1/include/rapidjson/document.h:1498:
> rapidjson::GenericValue<Encoding, Allocator>&
> rapidjson::GenericValue<Encoding, Allocator>::operator[](rapidjson::SizeType)
> [with Encoding = rapidjson::UTF8<>; Allocator =
> rapidjson::MemoryPoolAllocator<>; rapidjson::SizeType = unsigned int]:
> Assertion `index < data_.a.size' failed.
> Minidump with no thread info available.
> Minidump with no thread info available.
> Wrote minidump to
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/logs/be_tests/minidumps/unifiedbetests/528d83ca-a583-4564-d1354e90-99a7fff5.dmp
> Wrote minidump to
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/logs/be_tests/minidumps/unifiedbetests/528d83ca-a583-4564-d1354e90-99a7fff5.dmp
> /data/jenkins/workspace/impala-asf-master-core/repos/Impala/be/build/debug//util/runtime-profile-test:
> line 10: 23449 Aborted (core dumped)
> ${IMPALA_HOME}/bin/run-jvm-binary.sh
> ${IMPALA_HOME}/be/build/latest/service/unifiedbetests
> --gtest_filter=${GTEST_FILTER}
> --gtest_output=xml:${IMPALA_BE_TEST_LOGS_DIR}/${TEST_EXEC_NAME}.xml
> -log_filename="${TEST_EXEC_NAME}" "$@"
> Traceback (most recent call last):
> File
> "/data/jenkins/workspace/impala-asf-master-core/repos/Impala/bin/junitxml_prune_notrun.py",
> line 72, in <module>
> if __name__ == "__main__": main()
> File
> "/data/jenkins/workspace/impala-asf-master-core/repos/Impala/bin/junitxml_prune_notrun.py",
> line 69, in main
> junitxml_prune_notrun(options.filename)
> File
> "/data/jenkins/workspace/impala-asf-master-core/repos/Impala/bin/junitxml_prune_notrun.py",
> line 32, in junitxml_prune_notrun
> root = tree.parse(junitxml_filename)
> File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 647, in parse
> source = open(source, "rb")
> IOError: [Errno 2] No such file or directory:
> '/data/jenkins/workspace/impala-asf-master-core/repos/Impala/logs/be_tests/runtime-profile-test.xml'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
