[ 
https://issues.apache.org/jira/browse/IMPALA-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928335#comment-17928335
 ] 

ASF subversion and git services commented on IMPALA-13201:
----------------------------------------------------------

Commit 8f6eee94f3b067161fe724687cea27ce5a8ab04d in impala's branch 
refs/heads/branch-4.5.0 from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8f6eee94f ]

IMPALA-13761: Fix test_coord_only_pool_exec_groups

IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
TestAdmissionControllerWithACService due to unaccounted AdmissionD as
the extra statestore subscriber. This patch fix the issue by using
expected_subscribers and expected_num_impalads argument for
CustomClusterTestSuite._start_impala_cluster() and relies on wait
mechanism inside it.

This patch also does some adjustments:
1. Tweak __run_assert_systables_query to not use
   execute_query_using_vector from IMPALA-13694.
2. Remove default_impala_client() call, first added by IMPALA-13668, and
   use self.client instead.
3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
These make it possible to backport IMPALA-13201 and IMPALA-13761
together to older release/maintenance branch.

Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
  -k test_coord_only_pool custom_cluster/test_admission_controller.py

Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
Reviewed-on: http://gerrit.cloudera.org:8080/22486
Reviewed-by: Peter Rozsa <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>


> Queries Against System Tables Must Not Be Subject to Admission Control
> ----------------------------------------------------------------------
>
>                 Key: IMPALA-13201
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13201
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Jason Fehr
>            Assignee: Jason Fehr
>            Priority: Critical
>              Labels: workload-management
>
> Impala system tables are in-memory coordinator-only virtual tables without 
> any backing of data on disk.  Currently, the only system table is 
> sys.impala_query_live.  Since these tables only exist in coordinator memory, 
> queries that only select from these tables do not need to by subject to 
> admission control.
> Modify Impala so that queries that only reference system tables are not 
> subject to admission control and can run if there is enough available memory 
> on the coordinator.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to