[ 
https://issues.apache.org/jira/browse/IMPALA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928523#comment-17928523
 ] 

ASF subversion and git services commented on IMPALA-13761:
----------------------------------------------------------

Commit 443ca4e8abe6578ff1f077ba1b57f4034a78d880 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=443ca4e8a ]

IMPALA-13761: Fix test_coord_only_pool_exec_groups

IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
TestAdmissionControllerWithACService due to unaccounted AdmissionD as
the extra statestore subscriber. This patch fix the issue by using
expected_subscribers and expected_num_impalads argument for
CustomClusterTestSuite._start_impala_cluster() and relies on wait
mechanism inside it.

This patch also does some adjustments:
1. Tweak __run_assert_systables_query to not use
   execute_query_using_vector from IMPALA-13694.
2. Remove default_impala_client() call, first added by IMPALA-13668, and
   use self.client instead.
3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
These make it possible to backport IMPALA-13201 and IMPALA-13761
together to older release/maintenance branch.

Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
  -k test_coord_only_pool custom_cluster/test_admission_controller.py

Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
Reviewed-on: http://gerrit.cloudera.org:8080/22486
Reviewed-by: Peter Rozsa <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>


> TestAdmissionControllerWithACService.test_coord_only_pool_exec_groups fail
> --------------------------------------------------------------------------
>
>                 Key: IMPALA-13761
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13761
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Test
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>              Labels: broken-build
>             Fix For: Impala 4.6.0
>
>
> TestAdmissionControllerWithACService.test_coord_only_pool_exec_groups fail in 
> exhaustive with following error and stacktrace.
>  
> {noformat}
> Error Message
> AssertionError: Metric statestore.live-backends did not reach value 3 in 30s. 
> Actual value was '4'. Dumping debug webpages in JSON format... Dumped memz 
> JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/memz.json 
> Dumped metrics JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/metrics.json 
> Dumped queries JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/queries.json 
> Dumped sessions JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/sessions.json 
> Dumped threadz JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/threadz.json 
> Dumped rpcz JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/rpcz.json 
> Dumping minidumps for impalads/catalogds... Dumped minidump for Impalad PID 
> 3218906 Dumped minidump for Impalad PID 3219581 Dumped minidump for Catalogd 
> PID 3218871
> Stacktrace
> custom_cluster/test_admission_controller.py:1993: in 
> test_coord_only_pool_exec_groups
>     self.cluster.statestored.service.wait_for_live_subscribers(3, timeout=30)
> common/impala_service.py:505: in wait_for_live_subscribers
>     timeout=timeout, interval=interval)
> common/impala_service.py:145: in wait_for_metric_value
>     self.__metric_timeout_assert(metric_name, expected_value, timeout, value)
> common/impala_service.py:214: in __metric_timeout_assert
>     assert 0, assert_string
> E   AssertionError: Metric statestore.live-backends did not reach value 3 in 
> 30s. Actual value was '4'.
> E   Dumping debug webpages in JSON format...
> E   Dumped memz JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/memz.json
> E   Dumped metrics JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/metrics.json
> E   Dumped queries JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/queries.json
> E   Dumped sessions JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/sessions.json
> E   Dumped threadz JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/threadz.json
> E   Dumped rpcz JSON to 
> $IMPALA_HOME/logs/metric_timeout_diags_20250215_06:45:12/json/rpcz.json
> E   Dumping minidumps for impalads/catalogds...
> E   Dumped minidump for Impalad PID 3218906
> E   Dumped minidump for Impalad PID 3219581
> E   Dumped minidump for Catalogd PID 3218871
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to