[
https://issues.apache.org/jira/browse/IMPALA-13747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930226#comment-17930226
]
ASF subversion and git services commented on IMPALA-13747:
----------------------------------------------------------
Commit 841ac3c14b5e92d04b9c065d50a9f0db7485b013 in impala's branch
refs/heads/branch-4.5.0 from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=841ac3c14 ]
IMPALA-13747: Use fresh HS2 client for unique_database fixture
Just like IMPALA-13634 bug, unique_database fixture may taint
ImpalaTestSuite.client by setting 'sync_ddl=True' option and never
cleaning it up for test method usage.
This patch fixes unique_database fixture by always creating fresh HS2
client during CREATE DATABASE and DROP DATABASE.
Testing:
- Caught an assert error at test_set_fallback_db_for_functions
Expected: "default.fn() unknown for database default"
Actual: "functional.fn() unknown for database functional"
In this case, shared ImpalaTestSuite.client may have changed database
via ImpalaTestSuite.run_test_case() or
ImpalaTestSuite.execute_wrapper() in other test method.
Removing unused 'vector' argument somehow fixed the issue.
- For both query_test/test_udfs.py and metadata/test_ddl.py:
- Fixed flake8 issues and remove unused pytest fixture.
- Run and pass the tests in exhaustive exploration.
Change-Id: Ib503e829552d436035c57b489ffda0d0299f8405
Reviewed-on: http://gerrit.cloudera.org:8080/22471
Reviewed-by: Riza Suminto <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> unique_database fixture may taint ImpalaTestSuite.client
> --------------------------------------------------------
>
> Key: IMPALA-13747
> URL: https://issues.apache.org/jira/browse/IMPALA-13747
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> Just like IMPALA-13634 bug, unique_database fixture may taint
> ImpalaTestSuite.client by setting 'sync_ddl=True' option, but never cleaning
> it up for test method usage.
> [https://github.com/apache/impala/blob/856741b1e8371b983da10f23a166f19aac71f1f8/tests/conftest.py#L410-L412]
>
> unique_database fixture should use a fresh Impala client for both creating
> and dropping database.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
