[ 
https://issues.apache.org/jira/browse/IMPALA-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934471#comment-17934471
 ] 

ASF subversion and git services commented on IMPALA-13852:
----------------------------------------------------------

Commit a7fc8c977a73683fcabb296882ac32593526503d in impala's branch 
refs/heads/master from Daniel Becker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a7fc8c977 ]

IMPALA-13852: udf-ir.cc missing in ImpalaUdf

IMPALA-11623 separated out *ir.cc files into their own libraries. With
the change, the source file 'be/src/udf/CMakeLists.txt', which was
previously included in the ImpalaUdf library, is now not included. In
case of other libraries, it is intentional that *ir.cc files are not
included in the them as they are linked together with the *Ir libraries
to form the Impala executable. But ImpalaUdf is special because it is
shipped separately as part of the UDF SDK. Because of missing udf-ir.cc,
the functions defined in it, such as
FunctionContext::GetFunctionState(), are not present in libImpalaUdf.a.

This change adds udf-ir.cc to ImpalaUdf.

Testing:
 - verified manually that GetFunctionState() is present in
   libImpalaUdf.a

Change-Id: I7e8ad94931ced21f386e4981f36e0cf7e700ffaf
Reviewed-on: http://gerrit.cloudera.org:8080/22609
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> udf-ir.cc missing in ImpalaUdf
> ------------------------------
>
>                 Key: IMPALA-13852
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13852
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.2.0, Impala 4.5.0
>            Reporter: Daniel Becker
>            Assignee: Daniel Becker
>            Priority: Major
>              Labels: impala
>
> [IMPALA-11623|http://issues.apache.org/jira/browse/IMPALA-11623] separated 
> out *ir.cc files into their own libraries. With the change, the source file 
> 'be/src/udf/CMakeLists.txt', which was previously included in the ImpalaUdf 
> library, is now not included. In case of other libraries, it is intentional 
> that *ir.cc files are not included in the them as they are linked together 
> with the *Ir libraries to form the Impala executable. But ImpalaUdf is 
> special because it is shipped separately as part of the UDF SDK.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to