[
https://issues.apache.org/jira/browse/IMPALA-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941838#comment-17941838
]
Silka Simmen commented on IMPALA-13879:
---------------------------------------
Hi [~yx91490] Thanks for the patch.
Some thoughts from my side:
* Hardcoded environment variables in the service files:
Approach is OK, very transparent. After installing impala on a system, there is
some manual work needed in addition. A more comfortable approach I see, is to
use a wrapper script, that autodetects these variables with the option to
override them directly in the service file.
* In our build environment, I've adapted {{package/bin/impala.sh}} as a
wrapper script and removed a lot of its current functionality that is already
solved by systemd. So basically it just autotedects the environment variables
und uses {{exec}} to start the daemon.
* As a base for our own implementation of {{package/bin/impala.sh}}, I've used
this script of yours:
[https://github.com/apache/impala/blob/4.5.0/docker/daemon_entrypoint.sh] No
need to reinvent the wheel, autodetection is already solved quite nicely :-)
Maybe my approach has some drawbacks that I'm not yet aware of. I'm currently
working on building and testing impala release 4.5.0, so it's still work in
progress.
I'll try to make it accessable for you in Github, as soon as I'm confident it's
working and will share the link here. Do you have a better option to share my
code?
It's an own repo containing an rpmbuild spec file plus some stuff wrapped
around impala-4.5.0 sources.
Cheers
> Use systemd instead of init scripts to install services in RPM/DEB packages
> ---------------------------------------------------------------------------
>
> Key: IMPALA-13879
> URL: https://issues.apache.org/jira/browse/IMPALA-13879
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.5.0
> Environment: RHEL
> Reporter: Silka Simmen
> Assignee: XiangYang
> Priority: Major
>
> In Impala version 4.5.0 services are installed as SysVinit scripts in a
> RPM/DEB packages.
> For RHEL8 and RHEL9 SysVinit scripts, like they are written in Impala version
> 4.5.0, do not work. Since RHEL8 RHEL is not LSB compliant anymore:
> [https://access.redhat.com/solutions/6973382]
> Since major distributions as Debian or RHEL discontinued LSB support since a
> few years, systemd service files instead of of init scripts should be used to
> define services.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
