[
https://issues.apache.org/jira/browse/IMPALA-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943836#comment-17943836
]
ASF subversion and git services commented on IMPALA-13954:
----------------------------------------------------------
Commit 047cf9ff4d3c68c32be0965fbc3cb0c245d3b3b1 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=047cf9ff4 ]
IMPALA-13954: Validate num inserted rows via NumModifiedRows counter
This patch changes the way test validate num inserted rows from checking
the beeswax-specific result to checking NumModifiedRows counter from
query profile.
Remove skiping over hs2 protocol in test_chars.py and refactor
test_date_queries.py a bit to reduce test skiping. Added HS2_TYPES in
tests that requires it and fix some flake8 issues.
Testing:
Run and pass all affected tests.
Change-Id: I96eae9967298f75b2c9e4d0662fcd4a62bf5fffc
Reviewed-on: http://gerrit.cloudera.org:8080/22770
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Riza Suminto <[email protected]>
> Validate num inserted rows via NumModifiedRows counter
> ------------------------------------------------------
>
> Key: IMPALA-13954
> URL: https://issues.apache.org/jira/browse/IMPALA-13954
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> Many test files currently validate number of inserted rows by validating the
> beeswax protocol response like this:
> {code:java}
> ---- RESULTS
> : 2
> {code}
> It should be replaced with NumModifiedRows counter validation so that the
> test file is compatible with HS2 protocol, like this:
> {code:java}
> ---- RUNTIME_PROFILE
> NumModifiedRows: 2 {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
