[ 
https://issues.apache.org/jira/browse/IMPALA-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945243#comment-17945243
 ] 

ASF subversion and git services commented on IMPALA-13746:
----------------------------------------------------------

Commit 98f15044a14bcb21cb28e1482f3693c19c659241 in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=98f15044a ]

IMPALA-13746: Fix long ldap password handling in impala-shell+hs2-http

Before this patch impala-shell inserted a \n char after every 76 bytes.
The fix is to switch to a different function for encoding. The exact
semantics of base64 functions is described in
https://docs.python.org/3/library/base64.html

Based on impyla fix https://github.com/cloudera/impyla/pull/562 by
https://github.com/paulmayer (released in Impyla 0.21a3)

Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19
Reviewed-on: http://gerrit.cloudera.org:8080/22780
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>


> impala-shell handles long ldap passwords incorrectly
> ----------------------------------------------------
>
>                 Key: IMPALA-13746
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13746
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>            Reporter: Csaba Ringhofer
>            Assignee: Csaba Ringhofer
>            Priority: Critical
>              Labels: ramp-up
>
> Found this while checking if impyla fix 
> https://github.com/cloudera/impyla/pull/562 is also relevant for impala-shell.
> To reproduce:
> {code}
> python shell/impala_shell.py --protocol=hs2-http --ldap 
> --ldap_password_cmd="echo verylongpasswordthatcreatesalongbasic64encodin" 
> --auth_creds_ok_in_clear
> 2025-02-10 15:21:30 [Exception] type=<class 'ValueError'> in OpenSession. Num 
> remaining tries: 3 Invalid header value b'Basic 
> Y3NyaW5naG9mZXI6dmVyeWxvbmdwYXNzd29yZHRoYXRjcmVhdGVzYWxvbmdiYXNpYzY0ZW5jb2Rp\nbgo='
> {code}
> The problem comes from the \n added during base64 encoding.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to