[
https://issues.apache.org/jira/browse/IMPALA-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947460#comment-17947460
]
ASF subversion and git services commented on IMPALA-13738:
----------------------------------------------------------
Commit e7aa31296c8cb51572992294ab4fec8eb3d8541c in impala's branch
refs/heads/master from Noemi Pap-Takacs
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e7aa31296 ]
IMPALA-13738 (Part2): Clean up code in Catalog's table and partition interfaces
Prepare for FE/Catalog refactor by resolving some TODOs and
cleaning up unused code in most table and partition interfaces.
- removed dead code
- removed unused imports
- moved static functions from Util classes to interfaces
as default methods
Testing:
Run existing tests to validate changes.
Change-Id: I8d9c7ba876e39fa4f4d067761f25dc4ecfd55702
Reviewed-on: http://gerrit.cloudera.org:8080/22728
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Extract common code of IcebergTable and HdfsTable to a helper class
> -------------------------------------------------------------------
>
> Key: IMPALA-13738
> URL: https://issues.apache.org/jira/browse/IMPALA-13738
> Project: IMPALA
> Issue Type: Improvement
> Components: Catalog
> Reporter: Zoltán Borók-Nagy
> Assignee: Noémi Pap-Takács
> Priority: Major
> Labels: impala-iceberg
>
> Currently, IcebergTable has an underlying HdfsTable that gives us headaches
> from time to time.
> We should identify the common data members and logic between IcebergTable and
> HdfsTable and put them into a helper class and both IcebergTable and
> HdfsTable would use that class internally.
> HdfsTable and IcebergTable have a common base interface FeFsTable, but we
> cannot put useful code there.
> OTOH, HdfsTable and IcebergTable both extend Table, so as an alternative
> option (to composition), it might be possible to put common code into a newly
> introduced common base class:
> {noformat}
> Table
> ^
> |
> FsTable (NEW)
> ^
> / \
> / \
> HdfsTable IcebergTable{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
