[ 
https://issues.apache.org/jira/browse/IMPALA-14042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951693#comment-17951693
 ] 

ASF subversion and git services commented on IMPALA-14042:
----------------------------------------------------------

Commit 6831076983bedc0a8ba9ff199709ff93e6af2702 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=683107698 ]

IMPALA-14072: Fix NPE in Catalogd during rename.

test_rename_drop fail with NPE after IMPALA-14042. This is because
CatalogServiceCatalog.renameTable() return null for not finding the
database of oldTableName. This patch change renameTable() to return
Pair.create(null, null) for that scenario.

Refactor test_rename_drop slightly to ensure that invalidating the
renamed table and dropping it are successful.

Testing:
- Add checkNotNull precondition in
  CatalogOpExecutor.alterTableOrViewRename()
- Increase catalogd_table_rename_delay delay to 6s to ensure that DROP
  query happen in Catalogd before renameTable() called. Manually
  observed that No NPE is shown anymore.

Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a
Reviewed-on: http://gerrit.cloudera.org:8080/22899
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> TestConcurrentRename.test_rename_drop failure
> ---------------------------------------------
>
>                 Key: IMPALA-14042
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14042
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: gaurav singh
>            Assignee: Riza Suminto
>            Priority: Major
>              Labels: broken-build
>             Fix For: Impala 5.0.0
>
>
> h3. Error Message
> ImpalaBeeswaxException: Query 1844ef491bd88a30:c835c7fd00000000 failed: 
> TableNotFoundException: Table not found: test_rename_drop_aaefe83a.tbl2
> h3. Stacktrace
> custom_cluster/test_concurrent_rename.py:48: in test_rename_drop 
> self.execute_query("invalidate metadata {}2".format(name)) 
> common/impala_test_suite.py:1134: in wrapper return function(*args, **kwargs) 
> common/impala_test_suite.py:1176: in execute_query return 
> self.__execute_query(self.client, query, query_options) 
> common/impala_test_suite.py:1312: in __execute_query return 
> impalad_client.execute(query, user=user) common/impala_connection.py:505: in 
> execute fetch_exec_summary=fetch_exec_summary) beeswax/impala_beeswax.py:195: 
> in execute handle = self.__execute_query(query_string.strip(), user=user) 
> beeswax/impala_beeswax.py:293: in __execute_query 
> self.wait_for_finished(handle) beeswax/impala_beeswax.py:319: in 
> wait_for_finished raise ImpalaBeeswaxException(error_log, None) E 
> ImpalaBeeswaxException: Query 1844ef491bd88a30:c835c7fd00000000 failed: E 
> TableNotFoundException: Table not found: test_rename_drop_aaefe83a.tbl2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to