Joe McDonnell created IMPALA-14077:
--------------------------------------
Summary: Remove references to shaded imports from other projects
Key: IMPALA-14077
URL: https://issues.apache.org/jira/browse/IMPALA-14077
Project: IMPALA
Issue Type: Bug
Components: Frontend
Affects Versions: Impala 5.0.0
Reporter: Joe McDonnell
There are some pieces of code that reference shaded locations for libraries
rather than the original location. Here are a couple I found:
{noformat}
$ git grep import | grep shaded
fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:import
org.apache.curator.shaded.com.google.common.base.Preconditions;
fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:import
org.apache.curator.shaded.com.google.common.collect.Lists;
fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java:import
org.apache.kudu.shaded.com.google.common.base.Preconditions;
fe/src/main/java/org/apache/impala/util/ExprUtil.java:import
org.apache.curator.shaded.com.google.common.collect.Lists;
$ git grep import | grep hiveexec
fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java:import
hiveexec.com.google.common.base.Preconditions;{noformat}
This must be generated by IDEs. We should reference the regular base packages.
I don't know how you would enforce a rule against this, but maybe it is
possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
