[
https://issues.apache.org/jira/browse/IMPALA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952009#comment-17952009
]
ASF subversion and git services commented on IMPALA-14077:
----------------------------------------------------------
Commit d3814f445fc45be294cd5a4ccaf61c7c76f6b26d in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d3814f445 ]
IMPALA-14077: Remove references to shaded packages from other projects
IDEs can mistakenly add imports that reference shaded versions of
classes that are available normally. For example, one might use
org.apache.curator.shaded.com.google.common.base.Preconditions
vs
com.google.common.base.Preconditions
Some of these usages have crept back into the codebase, so this
removes those obvious cases. Some commands to find these cases:
git grep import | grep com.google | grep -v "import com"
git grep import | grep shade
git grep import | grep relocate
Testing:
- Ran a build
Change-Id: I7d09c757cb2a29a8e3187f05f3f71984fa897810
Reviewed-on: http://gerrit.cloudera.org:8080/22904
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Remove references to shaded imports from other projects
> -------------------------------------------------------
>
> Key: IMPALA-14077
> URL: https://issues.apache.org/jira/browse/IMPALA-14077
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> There are some pieces of code that reference shaded locations for libraries
> rather than the original location. Here are a couple I found:
> {noformat}
> $ git grep import | grep shaded
> fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:import
> org.apache.curator.shaded.com.google.common.base.Preconditions;
> fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:import
> org.apache.curator.shaded.com.google.common.collect.Lists;
> fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java:import
> org.apache.kudu.shaded.com.google.common.base.Preconditions;
> fe/src/main/java/org/apache/impala/util/ExprUtil.java:import
> org.apache.curator.shaded.com.google.common.collect.Lists;
> $ git grep import | grep hiveexec
> fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java:import
> hiveexec.com.google.common.base.Preconditions;{noformat}
> This must be generated by IDEs. We should reference the regular base
> packages. I don't know how you would enforce a rule against this, but maybe
> it is possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
