[ 
https://issues.apache.org/jira/browse/IMPALA-14109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955747#comment-17955747
 ] 

ASF subversion and git services commented on IMPALA-14109:
----------------------------------------------------------

Commit c45e3e796883d998dc982c62e8a99d601a29b94d in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c45e3e796 ]

IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled

This skipIf used the coordinator webui to check whether the flag
is set and skipped the test if the cluster was not running.
The skipIf was only used in custom cluster tests where the cluster
is restarted with new flags anyway, so the flags of the previous
cluster are not relevant.

Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1
Reviewed-on: http://gerrit.cloudera.org:8080/22960
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> hms_event_polling_disabled can skip tests based on cluster state
> ----------------------------------------------------------------
>
>                 Key: IMPALA-14109
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14109
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Csaba Ringhofer
>            Assignee: Csaba Ringhofer
>            Priority: Major
>
> hms_event_polling_disabled checks catalogd webui to check whether event 
> polling is enabled and defaults to false is unsuccessful.
> https://github.com/apache/impala/blob/b37f4509fa03359be77bd7966e40cb2ffd1ec3e4/tests/common/environ.py#L405
> This can lead to skipping the test without error in case the webui can't be 
> reached:
> bin/start-impala-cluster.py --kill
> impala-py.test tests/metadata/test_event_processing.py
> This doesn't makes sense, as this runs custom cluster tests that would 
> restart the cluster anyway.
> https://github.com/apache/impala/blob/b37f4509fa03359be77bd7966e40cb2ffd1ec3e4/tests/metadata/test_event_processing.py#L38



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to