[
https://issues.apache.org/jira/browse/IMPALA-14163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985987#comment-17985987
]
ASF subversion and git services commented on IMPALA-14163:
----------------------------------------------------------
Commit d36df0eb8847d527eeb4c62feb8a78a322605a3e in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d36df0eb8 ]
IMPALA-14163: Raise test_pool_config_change_while_queued MEM_LIMIT
test_pool_config_change_while_queued hit timeout at
TestAdmissionControllerWithACService. When running this test locally, we
notice that some trigger query ("select 'wait_for_config_change'")
passed when it is expected to be rejected (hit EXCEPTION during
admission).
This patch increase the MEM_LIMIT higher to 128GB to ensure rejection.
It also add wait_for_admission_control() that should immediately return
once trigger query hit exception. Removed redundant
"set enable_trivial_query_for_admission=false" query in
test_pool_config_change_while_queued.
Testing:
- Loop the test couple times and confirm that all trigger query
executions hit exception.
Change-Id: Iee808d0fc92308604ed0ee27dde795e9aa69eb5d
Reviewed-on: http://gerrit.cloudera.org:8080/23072
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> TestAdmissionControllerWithACService.test_pool_config_change_while_queued
> timing out
> ------------------------------------------------------------------------------------
>
> Key: IMPALA-14163
> URL: https://issues.apache.org/jira/browse/IMPALA-14163
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Priority: Critical
>
> TestAdmissionControllerWithACService.test_pool_config_change_while_queued
> still sometimes hits a timeout like this:
> {noformat}
> custom_cluster/test_admission_controller.py:1492: in
> test_pool_config_change_while_queued
> config.set_config_value(pool_name, config_str, 0)
> common/resource_pool_config.py:54: in set_config_value
> self.__wait_for_impala_to_pickup_config_change(pool_name, config_str,
> str(target_val))
> common/resource_pool_config.py:81: in
> __wait_for_impala_to_pickup_config_change
> metric_key, target_val, current_val)
> E AssertionError: Timed out waiting for
> admission-controller.pool-max-query-mem-limit.root.invalidTestPool to reach
> 0. Current: 1{noformat}
> This test was deflaked by IMPALA-14098, but this is happening after that fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
