[ 
https://issues.apache.org/jira/browse/IMPALA-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003504#comment-18003504
 ] 

ASF subversion and git services commented on IMPALA-14187:
----------------------------------------------------------

Commit 3089b918705f73bbace52919da247d20fec1681a in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3089b9187 ]

IMPALA-14187: (Addendum) Maintain consistent IMPALA_JAVA_TARGET

impala-config-java.sh (evaluated through impala-config.sh) can be
sourced twice: buildall.sh and run-all-tests.sh. When TEST_JDK_VERSION
or TEST_JAVA_HOME_OVERRIDE is set, run-all-tests.sh can reinitialize
IMPALA_JAVA_TARGET with different value than what it was during
buildall.sh.

This patch makes IMPALA_JAVA_TARGET consistent both during build and
test by restoring IMPALA_JAVA_TARGET to its original value at
run-all-tests.sh.

This patch assumes that TEST_JDK_VERSION or TEST_JAVA_HOME_OVERRIDE (if
set) is greater version than IMPALA_JDK_VERSION, but does not validate
it.

Testing:
Pass all FE test with IMPALA_JDK_VERSION=8 and TEST_JDK_VERSION=17.

Change-Id: Ia1e9d09ac086ea66a5f17ff1c0932f27ac5d5567
Reviewed-on: http://gerrit.cloudera.org:8080/23115
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Add control to change target version in maven-compiler-plugin
> -------------------------------------------------------------
>
>                 Key: IMPALA-14187
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14187
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>              Labels: jdk17
>             Fix For: Impala 5.0.0
>
>
> Impala is preparing to switch to JDK17 for Java compilation by default. While 
> the source version might remain in 1.8 for longer, we should experiment with 
> targeting binary version 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to