[
https://issues.apache.org/jira/browse/IMPALA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004342#comment-18004342
]
ASF subversion and git services commented on IMPALA-14207:
----------------------------------------------------------
Commit a766f197a7fd0297ab736ed24bd35f7c4568927e in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a766f197a ]
IMPALA-14207: Hook log4j to Glog in AdmissionD
log4j logs does not shows up in dedicated AdmissionD service. This is
because GlogAppender.Install is not called anywhere. It is called in
constructor of JniCatalog.java and JniFrontend.java, but AdmissionD does
not utilize either of them.
AdmissionD has call path to JniRequestPoolService.java. This patch adds
isAdmissiond parameter to JniRequestPoolService constructor to call
GlogAppender.Install and hook up log4j to Glog. Only AdmissionD sets
this parameter to true when initializing JniRequestPoolService. Note
that this hook up only happen if fair_scheduler_allocation_path flag is
not empty.
Testing:
Run few tests in TestAdmissionControllerWithACService and confirm log4j
logs appears in admissiond.INFO
Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79
Reviewed-on: http://gerrit.cloudera.org:8080/23140
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Yida Wu <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> log4j logs does not shows up in AdmissionD
> ------------------------------------------
>
> Key: IMPALA-14207
> URL: https://issues.apache.org/jira/browse/IMPALA-14207
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> log4j logs does not shows up in dedicated AdmissionD service. This is because
> GlogAppender.Install is not called anywhere. It called in JniCatalog.java and
> JniFrontend.java, but AdmissionD has neither those two.
>
> AdmissionD has call path to JniRequestPoolService.java. We can add function
> there to call GlogAppender.Install and hook up log4j to Glog.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
