[
https://issues.apache.org/jira/browse/IMPALA-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004868#comment-18004868
]
ASF subversion and git services commented on IMPALA-14209:
----------------------------------------------------------
Commit 4a7cb736a8a61ee31b165a8f6158b7e15cf0a32a in impala's branch
refs/heads/master from Venu Reddy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4a7cb736a ]
IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage
HIVE-28976 modified CommitTxnMessage to pass write ids in the message.
But, catalogd do not expect write ids in the CommitTxnMessage.
writeEventInfos is explicitly fetched from HMS using
getAllWriteEventInfo() API and populate them to its local
CommitTxnMessage object using CommitTxnMessage.addWriteEventInfo().
Since the write ids are already present in CommitTxnMessage, when we
do addWriteEventInfo() on it, write ids are added again to the
writeIds list in CommitTxnMessage and cause the
IndexOutOfBoundsException upon CommitTxnMessage.getTableObj(i).
Fix is to not populate the fetched WriteEventInfos to local
CommitTxnMessage object. Instead, use them directly.
Testing:
- Executed existing tests.
Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022
Reviewed-on: http://gerrit.cloudera.org:8080/23152
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Incorrect usage of commitTxnMessage to populate writeEventInfos
> ---------------------------------------------------------------
>
> Key: IMPALA-14209
> URL: https://issues.apache.org/jira/browse/IMPALA-14209
> Project: IMPALA
> Issue Type: Bug
> Components: Catalog
> Reporter: Venugopal Reddy K
> Assignee: Venugopal Reddy K
> Priority: Major
>
> With HIVE-28976, CommitTxnMessage is modified to pass write Ids in the
> message.
> But Impala do not expect write Ids in the CommitTxnMessage.
> writeEventInfoList is explicitly fetched from HMS using
> getAllWriteEventInfo() API and then populate the WriteEventInfo to its local
> CommitTxnMessage object using CommitTxnMessage.addWriteEventInfo() API.
> Since the write Ids are already present in CommitTxnMessage, when we do
> addWriteEventInfo() on it, write Ids would get added again to the
> CommitTxnMessage and can cause the exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
