[
https://issues.apache.org/jira/browse/IMPALA-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009030#comment-18009030
]
ASF subversion and git services commented on IMPALA-14214:
----------------------------------------------------------
Commit 5bad0daf72038b377776d0af15777b9975fe7b5b in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5bad0daf7 ]
IMPALA-14214: Compile OpenTelemetry-cpp Against STDLIB
Consumes the new toolchain builds that compiled the OpenTelemetry-cpp
SDK libraries against the standard C++ library instead of the SDK's
nostd translation layer.
Change-Id: Icf06710d5f7987f43cb8bae5450b657f251f199b
Reviewed-on: http://gerrit.cloudera.org:8080/23192
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Jason Fehr <[email protected]>
> Compile Toolchain OpenTelemetry SDK Against STDLIB
> --------------------------------------------------
>
> Key: IMPALA-14214
> URL: https://issues.apache.org/jira/browse/IMPALA-14214
> Project: IMPALA
> Issue Type: Improvement
> Components: Toolchain
> Affects Versions: Impala 4.5.0
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Major
> Labels: toolchain
>
> The OpenTelemetry C++ SDK has [a
> doc|https://github.com/open-telemetry/opentelemetry-cpp/blob/cafcfaab6c504da80d7f7571814d1f36989db0c7/docs/building-with-stdlib.md]
> about compiling against STDLIB. By default, the SDK compiles against a
> translation layer named "nostd". This additional layer ensures application
> binary interface compatibility which is required when using OpenTelemetry as
> a shared library.
> Since we compile OpenTelemetry as a static library, this additional layer is
> not needed. The OpenTelemetry SDK doc states:
> {noformat}
> Compiling OpenTelemetry SDK from source using standard library classes:
> std::map, std::string_view, std::span, std::variant instead of nostd:: yields
> better performance and debugability at expense of potentially losing ABI
> compatibility.{noformat}
> Since Impala does not need ABI compatibility, we should compile the toolchain
> OpenTelemetry C++ SDK against stdlib.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
