[
https://issues.apache.org/jira/browse/IMPALA-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011238#comment-18011238
]
ASF subversion and git services commented on IMPALA-13809:
----------------------------------------------------------
Commit 5414c3009890a736901b6ae3b56b9953b1992de7 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5414c3009 ]
IMPALA-13809: Update list of excluded locations for the code coverage report
This adds be/src/gutil and be/src/kudu to the list of excluded
locations for the code coverage report. These directories are third-party
party code that have been vendored into the Impala repository. There
is a fair amount of unused code in those directories simply because it
is easier to maintain that way. Impala's tests aren't intending to test
that code.
Testing:
- Ran code coverage with the updated list
Change-Id: I7f3aa971e50b2c454e9ca607fb9d49d7cc3593ae
Reviewed-on: http://gerrit.cloudera.org:8080/23084
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Update list of excluded locations for code coverage in bin/coverage_helper.sh
> -----------------------------------------------------------------------------
>
> Key: IMPALA-13809
> URL: https://issues.apache.org/jira/browse/IMPALA-13809
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> Impala has some third party libraries checked into the code base. This can
> distort the code coverage numbers, because there are various files that we
> simply do not use at all. This is particularly true for be/src/kudu and
> be/src/gutil, but it is also true for be/src/thirdparty.
> We should update bin/coverage_helper.sh to exclude these directories.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
