[ https://issues.apache.org/jira/browse/IMPALA-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017938#comment-18017938 ]
ASF subversion and git services commented on IMPALA-13731: ---------------------------------------------------------- Commit 42e448875b8359a9d6dda9f9c8494db9cbe5a628 in impala's branch refs/heads/master from Riza Suminto [ https://gitbox.apache.org/repos/asf?p=impala.git;h=42e448875 ] IMPALA-13731: Deflake TestAsyncLoadData.test_async_load This patch attempt to deflake TestAsyncLoadData::test_async_load by allowing exec_end_state == PENDING if enable_async_load_data. This is OK because, if enable_async_load_data is true, async_exec_thread_ might be slightly slower to start and transition the query to RUNNING. wait_time is also relaxed to at least 2 seconds because wait_start not strictly starts at the point when the async_exec_thread_ starts. This patch does not change assertion / behavior in sync code path (enable_async_ddl_execution=false). Testing: Loop and pass TestAsyncLoadData 50 times. Change-Id: I8776a432e60a1167ad54778e81046421df15cf37 Reviewed-on: http://gerrit.cloudera.org:8080/23360 Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Reviewed-by: Jason Fehr <jf...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > TestAsyncLoadData.test_async_load failed in PENDING_STATE > --------------------------------------------------------- > > Key: IMPALA-13731 > URL: https://issues.apache.org/jira/browse/IMPALA-13731 > Project: IMPALA > Issue Type: Bug > Reporter: Quanlong Huang > Assignee: Riza Suminto > Priority: Critical > Fix For: Impala 5.0.0 > > > Saw the test failed in > [https://jenkins.impala.io/job/ubuntu-20.04-dockerised-tests/2851] > Stacktrace > {code:python} > metadata/test_load.py:239: in test_async_load > assert(exec_end_state == running_state) > E assert 'PENDING_STATE' == 'RUNNING_STATE' > E - PENDING_STATE > E ? ^^ ^ > E + RUNNING_STATE > E ? ^^ ^{code} > Standard Error > {noformat} > SET > client_identifier=metadata/test_load.py::TestAsyncLoadData::()::test_async_load[enable_async_load_data_execution:True|protocol:hs2|table_format:text/none|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;'a; > -- connecting to: localhost:21000 > -- connecting to localhost:21050 with impyla > -- 2025-02-03 02:44:11,199 INFO MainThread: Closing active operation > -- connecting to localhost:28000 with impyla > -- 2025-02-03 02:44:11,217 INFO MainThread: Closing active operation > SET > client_identifier=metadata/test_load.py::TestAsyncLoadData::()::test_async_load[enable_async_load_data_execution:True|protocol:hs2|table_format:text/none|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;'a; > SET sync_ddl=False; > -- executing against localhost:21000 > DROP DATABASE IF EXISTS `test_async_load_28be8ca9` CASCADE; > -- 2025-02-03 02:44:11,228 INFO MainThread: Started query > 914e9ab9f501b46d:261f902700000000 > SET > client_identifier=metadata/test_load.py::TestAsyncLoadData::()::test_async_load[enable_async_load_data_execution:True|protocol:hs2|table_format:text/none|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;'a; > SET sync_ddl=False; > -- executing against localhost:21000 > CREATE DATABASE `test_async_load_28be8ca9`; > -- 2025-02-03 02:44:16,570 INFO MainThread: Started query > 704d618307f55943:61a9418100000000 > -- 2025-02-03 02:44:16,622 INFO MainThread: Created database > "test_async_load_28be8ca9" for test ID > "metadata/test_load.py::TestAsyncLoadData::()::test_async_load[enable_async_load_data_execution: > True | protocol: hs2 | table_format: text/none | exec_option: > {'test_replan': 1, 'batch_size': 0, 'num_nodes': 0, > 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, > 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0}]" > -- connecting to localhost:21050 with impyla > -- 2025-02-03 02:44:16,639 INFO MainThread: Closing active operation > -- executing against localhost:21000 > create table test_async_load_28be8ca9.test_load_nopart_hs2_True like > functional.alltypesnopart location > '/test-warehouse/test_load_staging_hs2_True'; > -- 2025-02-03 02:44:21,404 INFO MainThread: Started query > da4fc35e99ec948d:fb8d390d00000000 > -- executing against Impala at localhost:21050 > select count(*) from test_async_load_28be8ca9.test_load_nopart_hs2_True; > -- dd412a40c2ed4db6:287544e400000000: getting log for operation > -- dd412a40c2ed4db6:287544e400000000: getting runtime profile operation > -- dd412a40c2ed4db6:287544e400000000: closing query for operation > -- 2025-02-03 02:44:21,534 INFO MainThread: Closing active operation > -- executing against Impala at localhost:21050 > use functional; > -- 62493ea72162cae0:517bb58400000000: getting log for operation > -- 62493ea72162cae0:517bb58400000000: getting runtime profile operation > -- 62493ea72162cae0:517bb58400000000: closing query for operation > -- 2025-02-03 02:44:21,542 INFO MainThread: Closing active operation > -- executing against Impala at localhost:21050 > load data inpath '/test-warehouse/test_load_staging_hs2_True' into > table test_async_load_28be8ca9.test_load_nopart_hs2_True; > Started query dd41abd9ffc34de6:a0767cf800000000 > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: getting state > -- dd41abd9ffc34de6:a0767cf800000000: closing query for operation > -- 2025-02-03 02:44:25,564 INFO MainThread: Closing active operation > -- closing connection to: localhost:21050{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org