[ https://issues.apache.org/jira/browse/IMPALA-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019894#comment-18019894 ]
ASF subversion and git services commented on IMPALA-14406: ---------------------------------------------------------- Commit 492b2b7f46af8a2b0e0a868f3947916bb822e2a7 in impala's branch refs/heads/master from Daniel Vanko [ https://gitbox.apache.org/repos/asf?p=impala.git;h=492b2b7f4 ] IMPALA-14406: Fix test_column_case_sensitivity for newer Iceberg versions New test introduced in IMPALA-14290 depends on the Iceberg versions, because newer ones (e.g. 1.5.2) will show {"start_time_month":"646","end_time_day":"19916"} instead of {"start_time_day":null,"end_time_month":null,"start_time_month":"646","end_time_day":"19916"} The test now accepts both cases. Testing: * ran query_test/test_iceberg.py with both Iceberg 1.3.1 and 1.5.2 Change-Id: I17e368ac043d1fbf80a78dcac6ab1be5a297b6ea Reviewed-on: http://gerrit.cloudera.org:8080/23389 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > test_column_case_sensitivity fails on builds with newer Iceberg > --------------------------------------------------------------- > > Key: IMPALA-14406 > URL: https://issues.apache.org/jira/browse/IMPALA-14406 > Project: IMPALA > Issue Type: Bug > Reporter: Dániel Gábor Vankó > Assignee: Dániel Gábor Vankó > Priority: Major > Labels: broken-build > > test_column_case_sensitivity fails in some build > newly introduced tests in QueryTest/iceberg-column-case-sensitivity-issue by > [IMPALA-14290|http://issues.apache.org/jira/browse/IMPALA-14290] > Error Message > {noformat} > query_test/test_iceberg.py:280: in test_column_case_sensitivity > self.run_test_case('QueryTest/iceberg-column-case-sensitivity-issue', > common/impala_test_suite.py:979: in run_test_case > self.__verify_results_and_errors(vector, test_section, result, use_db) > common/impala_test_suite.py:775: in __verify_results_and_errors > verify_raw_results(test_section, result, vector, > common/test_result_verifier.py:540: in verify_raw_results > VERIFIER_MAP[verifier](expected, actual) common/test_result_verifier.py:322: > in verify_query_result_is_equal assert expected_results == actual_results > E assert Comparing QueryTestResults (expected vs actual): E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"646","end_time_day":"19916"}',1,1 > != '{"start_time_month":"646","end_time_day":"19916"}',1,1 E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"647","end_time_day":"19916"}',1,1 > != '{"start_time_month":"647","end_time_day":"19916"}',1,1 E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"647","end_time_day":"19947"}',2,2 > != '{"start_time_month":"647","end_time_day":"19947"}',2,2{noformat} > Stacktrace > {noformat} > query_test/test_iceberg.py:280: in test_column_case_sensitivity > self.run_test_case('QueryTest/iceberg-column-case-sensitivity-issue', > common/impala_test_suite.py:979: in run_test_case > self.__verify_results_and_errors(vector, test_section, result, use_db) > common/impala_test_suite.py:775: in __verify_results_and_errors > verify_raw_results(test_section, result, vector, > common/test_result_verifier.py:540: in verify_raw_results > VERIFIER_MAP[verifier](expected, actual) > common/test_result_verifier.py:322: in verify_query_result_is_equal > assert expected_results == actual_results > E assert Comparing QueryTestResults (expected vs actual): > E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"646","end_time_day":"19916"}',1,1 > != '{"start_time_month":"646","end_time_day":"19916"}',1,1 > E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"647","end_time_day":"19916"}',1,1 > != '{"start_time_month":"647","end_time_day":"19916"}',1,1 > E > '{"start_time_day":null,"end_time_month":null,"start_time_month":"647","end_time_day":"19947"}',2,2 > != '{"start_time_month":"647","end_time_day":"19947"}',2,2{noformat} > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org