[
https://issues.apache.org/jira/browse/IMPALA-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040597#comment-18040597
]
ASF subversion and git services commented on IMPALA-14455:
----------------------------------------------------------
Commit 2ac5a24dc0cfc9c9e7a1fc86cccf94cd1a2900af in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2ac5a24dc ]
IMPALA-14455: Cleanup OpenTelemetry Tracing Startup Flags
Fixes several issues with the OpenTelemetry tracing startup flags:
1. otel_trace_beeswax -- Removes this hidden flag which enabled
tracing of queries submitted over Beeswax. Since this protocol is
deprecated and no tests assert the traces generated by Beeswax
queries, this flag was removed to eliminate an extra check when
determining if OpenTelemetry tracing should be enabled.
2. otel_trace_tls_minimum_version -- Fixes parsing of this flag's
value. This flag is in the format "tlsv1.2" or "tlsv1.3", but the
OpenTelemetry C++ SDK expects the minimum TLS version to be in the
format "1.2" or "1.3". The code now removes the "tlsv" prefix before
passing the value to the OpenTelemetry C++ SDK.
3. otel_trace_tls_insecure_skip_verify -- Fixes the guidance to only
set this flag to true in dev/testing.
Adds ctest tests for the functions that configure the TraceProvider
singleton to ensure startup flags are correctly parsed and applied.
Modifies the http_exporter_config and init_otel_tracer function
signatures in otel.cc to return the actual object they create instead
of a Status since these functions only ever returned OK.
Updates the OpenTelemetry collector docker-compose file to support
the collector receiving traces over both HTTP and HTTPS. This setup
is used to manually smoke test the integration from Impala to an
OpenTelemetry collector.
Change-Id: Ie321fa37c0fd260f783dc6cf47924d53a06d82ea
Reviewed-on: http://gerrit.cloudera.org:8080/23440
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
> OpenTelemetry Tracing Startup Flag Cleanup
> ------------------------------------------
>
> Key: IMPALA-14455
> URL: https://issues.apache.org/jira/browse/IMPALA-14455
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Critical
>
> Several issues with the OTel startup flags:
> * -otel_trace_ssl_ciphers -- shows a default of "", should be the value of
> FLAGS_ssl_cipher_list
> * -otel_trace_tls_cipher_suites -- shows a default of "", should be the value
> of FLAGS_tls_ciphersuites
> * -otel_trace_tls_minimum_version -- shows a default of "", should be the
> value of FLAGS_ssl_minimum_version
> * -otel_trace_tls_insecure_skip_verify -- says "false" should only be used in
> dev/testing, that is backwards. This flag should only be "true" in
> dev/testing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
