[
https://issues.apache.org/jira/browse/IMPALA-13371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Smith updated IMPALA-13371:
-----------------------------------
Labels: jdk17 (was: )
> Avoid throwing exceptions in FileSystemUtil::FindFileInPath()
> -------------------------------------------------------------
>
> Key: IMPALA-13371
> URL: https://issues.apache.org/jira/browse/IMPALA-13371
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Critical
> Labels: jdk17
> Fix For: Impala 4.5.0
>
>
> Some function in std::filesystem can throw exceptions in some scenarios. We
> should catch the exception in all cases or use and overload with noexcept.
> Even if the error is fatal throwing and exception can lead to not logging it
> properly.
> An example is filesystem:exists():
> https://github.com/apache/impala/blob/22723d0f276468a25553f007dc65b21d79bd821d/be/src/util/filesystem-util.cc#L271
> Other functions use an overload with noexcept:
> https://github.com/apache/impala/blob/22723d0f276468a25553f007dc65b21d79bd821d/be/src/util/filesystem-util.cc#L75
> https://en.cppreference.com/w/cpp/filesystem/exists
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
