[
https://issues.apache.org/jira/browse/IMPALA-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046130#comment-18046130
]
ASF subversion and git services commented on IMPALA-13917:
----------------------------------------------------------
Commit e22c0d33d64aed93a9df1c7a0ca63308595252a5 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e22c0d33d ]
IMPALA-13917 (part 1): Remove Beeswax from protocol dimension
Beeswax protocol has been due for deprecation in a long time. This patch
remove BEESWAX from create_client_protocol_dimension(). This will limit
protocol dimension to [HS2, HS2_HTTP] by default. It is still possible
to include BEESWAX again for testing if DEFAULT_TEST_PROTOCOL env var is
set to 'beeswax', such as:
DEFAULT_TEST_PROTOCOL=beeswax impala-py.test custom_cluster/test_ipv6.py
This patch does not disable beeswax server yet. Some tests that
specifically test against beeswax protocol, such as test_beeswax.py,
will continue to work. ImpalaTestSuite.beeswax_client also remain
unchanged.
Testing:
Run following command and confirm that beeswax protocol is skipped.
impala-py.test --collect-only --exploration=exhaustive \
custom_cluster/test_ipv6.py
Change-Id: I3cff79f59305b5d44944804ed1f1b92838575495
Reviewed-on: http://gerrit.cloudera.org:8080/23076
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Riza Suminto <[email protected]>
> Remove BEESWAX from create_client_protocol_dimension
> ----------------------------------------------------
>
> Key: IMPALA-13917
> URL: https://issues.apache.org/jira/browse/IMPALA-13917
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> To complete hs2 test protocol migration, we need to remove BEESWAX from
> create_client_protocol_dimension() and VALID_TEST_PROTOCOLS.
> [https://github.com/apache/impala/blob/4617c2370faad08b44f4cffad1eda229d78696ee/tests/common/test_dimensions.py#L166]
>
> [https://github.com/apache/impala/blob/4617c2370faad08b44f4cffad1eda229d78696ee/tests/conftest.py#L44]
>
> Must deprecate beeswax_client_protocol_dimension() as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
