[
https://issues.apache.org/jira/browse/IMPALA-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046372#comment-18046372
]
Raghav Jindal commented on IMPALA-6282:
---------------------------------------
[~tarmstrong] / [~philip] / [~jinchul] Is this issue still open ?
> Not easy to find where the error happens in be unit test
> --------------------------------------------------------
>
> Key: IMPALA-6282
> URL: https://issues.apache.org/jira/browse/IMPALA-6282
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Jin Chul Kim
> Priority: Minor
> Labels: newbie
>
> In expr-test, the line numbers where the failures happen are not helpful when
> we use TestValue/Test* which are helper functions in
> be/src/exprs/expr-test.cc.
> The line numbers mean assertion line in helper functions, but we expect line
> numbers of actual test failures(i.e. caller's line number). I think we can
> get caller's line number by using boost stacktrace:
> https://github.com/boostorg/stacktrace
> {noformat}
> [ RUN ] ExprTest.TimestampFunctions
> be/src/exprs/expr-test.cc:257: Failure
> Value of: result_types[0].type
> Actual: "null"
> Expected: TypeToOdbcString(expr_type.type)
> Which is: "int"
> NULL
> be/src/exprs/expr-test.cc:257: Failure
> Value of: result_types[0].type
> Actual: "null"
> Expected: TypeToOdbcString(expr_type.type)
> Which is: "string"
> NULL
> be/src/exprs/expr-test.cc:257: Failure
> Value of: result_types[0].type
> Actual: "tinyint"
> Expected: TypeToOdbcString(expr_type.type)
> Which is: "int"
> 0
> be/src/exprs/expr-test.cc:257: Failure
> Value of: result_types[0].type
> Actual: "null"
> Expected: TypeToOdbcString(expr_type.type)
> Which is: "int"
> NULL
> be/src/exprs/expr-test.cc:257: Failure
> Value of: result_types[0].type
> Actual: "null"
> Expected: TypeToOdbcString(expr_type.type)
> Which is: "string"
> NULL{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
