[
https://issues.apache.org/jira/browse/IMPALA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050421#comment-18050421
]
ASF subversion and git services commented on IMPALA-13679:
----------------------------------------------------------
Commit 5ae0d8f94843de4a0835de6cf82651d74c4901a0 in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5ae0d8f94 ]
IMPALA-13679: Fix ASAN Failure in Workload Management Tests
The TickerSecondsBool class defined in ticker.h is used to
process queued completed queries at specified intervals.
This class references variables defined outside of it. The
workload management code never properly shuts down this
ticker resulting in it sometimes, during shutdown, to
access variables that have already been released.
Removes the Ticker class leveraging the available
primitives of the std::condition_variable type.
The Ticker class was originally developed to avoid spurious
wakeups of a std::condition_variable, but the functionality
provided by the Ticker class can be eliminated by leveraging
the built in functionality of std::condition_variable.
In the workload-management-worker.cc file, adds the static
keyword to variables that are intended to be used only in
that file.
Testing
* workload management custom cluster tests passed locally
and in jenkins build
* TSAN/ASAN builds passed with workload management enabled
on the EE test impalad
Change-Id: I9a29f4f788cf7259c263a17272e86acdda5caa77
Reviewed-on: http://gerrit.cloudera.org:8080/23818
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> ASAN failure use-after-free during custom-cluster tests in
> test_ignored_sqls_not_written()
> ------------------------------------------------------------------------------------------
>
> Key: IMPALA-13679
> URL: https://issues.apache.org/jira/browse/IMPALA-13679
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.5.0
> Reporter: Laszlo Gaal
> Assignee: Jason Fehr
> Priority: Critical
> Labels: broken-build, flaky
>
> On private infrastructure we have observed the following use-after-free error
> in an address sanitizer build:
> {code}
> SUMMARY: AddressSanitizer: heap-use-after-free
> /data/jenkins/workspace/impala-asf-master-core-asan-arm/repos/Impala/be/src/util/ticker.h:119:41
> in impala::Ticker<std::chrono::duration<long, std::ratio<1l, 1l> >,
> bool>::run()
> Shadow bytes around the buggy address:
> 0x200fe56372a0: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd
> 0x200fe56372b0: fa fa fa fa fd fd fd fd fd fd fd fd fa fa fa fa
> 0x200fe56372c0: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd
> 0x200fe56372d0: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fa
> 0x200fe56372e0: fa fa fa fa fd fd fd fd fd fd fd fd fa fa fa fa
> =>0x200fe56372f0: fd fd[fd]fd fd fd fd fd fa fa fa fa fd fd fd fd
> 0x200fe5637300: fd fd fd fd fa fa fa fa 00 00 00 00 00 00 00 05
> 0x200fe5637310: fa fa fa fa fd fd fd fd fd fd fd fd fa fa fa fa
> 0x200fe5637320: 00 00 00 00 00 00 00 00 fa fa fa fa 00 00 00 00
> 0x200fe5637330: 00 00 00 05 fa fa fa fa fd fd fd fd fd fd fd fd
> 0x200fe5637340: fa fa fa fa fd fd fd fd fd fd fd fd fa fa fa fa
> Shadow byte legend (one shadow byte represents 8 application bytes):
> Addressable: 00
> Partially addressable: 01 02 03 04 05 06 07
> Heap left redzone: fa
> Freed heap region: fd
> Stack left redzone: f1
> Stack mid redzone: f2
> Stack right redzone: f3
> Stack after return: f5
> Stack use after scope: f8
> Global redzone: f9
> Global init order: f6
> Poisoned by user: f7
> Container overflow: fc
> Array cookie: ac
> Intra object redzone: bb
> ASan internal: fe
> Left alloca redzone: ca
> Right alloca redzone: cb
> ==4121003==ABORTING
> {code}
> Commits since the last successful ASAN build:
> # IMPALA-13656: MERGE redundantly accumulates memory in HDFS WRITER (detail)
> # IMPALA-13592: Set IV length before setting IV in OpenSsl (detail)
> # IMPALA-13253: Add option to enable keepalive for client connections (detail)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
