[ 
https://issues.apache.org/jira/browse/IMPALA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050917#comment-18050917
 ] 

ASF subversion and git services commented on IMPALA-14667:
----------------------------------------------------------

Commit 25d9caad006165cdd0b650fc9da53d209c00dc2e in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=25d9caad0 ]

IMPALA-14667: Remove reference to pytest.config

pytest.config global variable has been removed since pytest 5.0.
https://docs.pytest.org/en/stable/deprecations.html#pytest-config-global

This patch remove direct reference to pytest.config. Instead, it hook
pytest config object to ImpalaTestClusterProperties singleton at
pytest_configure() method at conftest.py.

Added pytest_config() classmethod in BaseTestSuite as a shortcut to
access ImpalaTestClusterProperties.get_instance().pytest_config().

Testing:
- Pass core tests.

Change-Id: Ieb09a9c8c1f474c355188b46a0ea913da6c2a38b
Reviewed-on: http://gerrit.cloudera.org:8080/23840
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Remove reference to pytest.config
> ---------------------------------
>
>                 Key: IMPALA-14667
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14667
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure, Test
>    Affects Versions: Impala 5.0.0
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>             Fix For: Impala 5.0.0
>
>
> pytest.config global variable has been removed since pytest 5.0.
> [https://docs.pytest.org/en/stable/deprecations.html#pytest-config-global]
> As an alternative, we can hook pytest config object to 
> ImpalaTestClusterProperties singleton at pytest_configure() method at 
> conftest.py. This is the first step towards upgrading to higher version of 
> pytest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to