[
https://issues.apache.org/jira/browse/IMPALA-14674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18051971#comment-18051971
]
ASF subversion and git services commented on IMPALA-14674:
----------------------------------------------------------
Commit eb8c8bd4ceb233b7cc17222ff431fa8aab7694b3 in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eb8c8bd4c ]
IMPALA-14674: Implement connect_timeout_ms for HS2-HTTP
Implements connect_timeout_ms support for HS2-HTTP. This only applies
the timeout while establishing the connection, so later requests do not
timeout. This is preferrable to configuring http_socket_timeout_s, which
can result in timing out operations that just take awhile to execute.
Removed ImpalaHttpClient.setTimeout as it's unused and not part of the
specification for TTransportBase.
Testing:
- updates tests now that HS2-HTTP supports connect_timeout_ms
- test_impala_shell_timeout for HS2-HTTP without http_socket_timeout_s
- marks test_http_socket_timeout to run serially because it relies on
short timeouts; inconsistent behavior can leave a dangling session
Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2
Reviewed-on: http://gerrit.cloudera.org:8080/23499
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Michael Smith <[email protected]>
> Support connect_timeout_ms for HS2-HTTP
> ---------------------------------------
>
> Key: IMPALA-14674
> URL: https://issues.apache.org/jira/browse/IMPALA-14674
> Project: IMPALA
> Issue Type: Improvement
> Components: Clients
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> HS2-HTTP has not previously implemented {{connect_timeout_ms}} to time out
> connections that have been closed or became unavailable (like a node
> disappearing from a load balancer) because of concerns around the HS2-HTTP
> client closing and re-opening connections frequently on a bad endpoint. That
> also resulted in a warning whenever using HS2-HTTP of
> {code}
> Warning: --connect_timeout_ms is currently ignored with HTTP transport.
> {code}
> IMPALA-14460 addresses some of that concern by re-using the connection if
> available and retrying closed connections only under specific circumstances.
> {{http_socket_timeout_ms}} was added to provide an alternative, but it
> applies to the whole HTTP request. Long-running requests - like
> ExecuteStatement when planning is very involved - would require a longer
> timeout, so setting a default is challenging. In some environments, it may
> still make sense to set a default matching the lifetime of load balancer
> timeouts, but those will vary by environment. Also see IMPALA-14440.
> We should support {{connect_timeout_ms}} only for the portion of the HS2-HTTP
> protocol where a socket connection is established, and use
> {{http_socket_timeout_ms}} for the remainder of the session when sending HTTP
> requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
