[
https://issues.apache.org/jira/browse/IMPALA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18054266#comment-18054266
]
ASF subversion and git services commented on IMPALA-14682:
----------------------------------------------------------
Commit c9bfdbb272238a73e95e483c823f6b54f022de0d in impala's branch
refs/heads/master from Yida Wu
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c9bfdbb27 ]
IMPALA-14682: Use centralized async cleanup for admission state cleanup
In IMPALA-14605, we added a mechanism to clean up the admission state
asynchronously. This patch refactors all admission state deletions
to use this centralized async method, making it easier to reason
about when admission state is removed and to detect cases where a
query’s admission state is not properly cleared.
Additionally, this refactoring is a necessary step for future
improvements, such as implementing time-based deletion.
Also updated test_admission_state_map_mem_leak to verify the
admission state number using the new global metric
admission-control-service.num-queries as it is more stable than
checking the log.
Tests:
Passed core tests.
Passed exhaustive custom_cluster/test_admission_controller.py test.
Change-Id: I04f46f2e42ec5e50f4dcccb6b73a34a376615ab0
Reviewed-on: http://gerrit.cloudera.org:8080/23873
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Use centralized async cleanup for admission state cleanup
> ---------------------------------------------------------
>
> Key: IMPALA-14682
> URL: https://issues.apache.org/jira/browse/IMPALA-14682
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 4.5.0
> Reporter: Yida Wu
> Assignee: Yida Wu
> Priority: Major
>
> In IMPALA-14605, we added CleanupAdmissionStateMapAsync() to clean up the
> admission state asynchronously. It would be better to migrate all deletion
> paths to use this centralized async method. This makes it easier to track
> when and if the admission state is removed. Additionally, this refactoring is
> a necessary step for future improvements, such as implementing time-based
> deletion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
