[
https://issues.apache.org/jira/browse/IMPALA-14710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055343#comment-18055343
]
ASF subversion and git services commented on IMPALA-14710:
----------------------------------------------------------
Commit 9220b9699fabbcf06b134a023807ce328e43a2ea in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9220b9699 ]
IMPALA-14710: Fixed flaky test in TestReduceExprShuttle
The charset system property is being set in CalciteCompilerFactory.
It seems that if this test is run via
mvn clean install test
...it runs fine, but if it is called via
mvn clean install -Dtest=TestReduceExprShuttle#testFoldConcatString
... the static initializer isn't called.
This could either be fixed by importing CalciteCompilerFactory or
explicitly setting the static initializer in this class. The latter
was chosen because it would be awkward to have a java class only
imported due to a static initializer. However, the downside is that
this is duplicate code.
Change-Id: Iecb124f43bd7090411bdf1bb8203c15d75158154
Reviewed-on: http://gerrit.cloudera.org:8080/23919
Reviewed-by: Joe McDonnell <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Michael Smith <[email protected]>
> Flaky test in TestReduceExprShuttle
> -----------------------------------
>
> Key: IMPALA-14710
> URL: https://issues.apache.org/jira/browse/IMPALA-14710
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 5.0.0
> Reporter: Steve Carlin
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> The test seems to be failing because the charset isn't being set properly.
> The charset is set via a static initializer in CalciteCompilerFactory. I
> think this is getting called when
> mvn clean install test
> is run
> but not get getting called when
> mvn clean install -Dtest=TestReduceExprShuttle#testFoldConcatString
> is run.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
