[
https://issues.apache.org/jira/browse/IMPALA-14715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056076#comment-18056076
]
ASF subversion and git services commented on IMPALA-14715:
----------------------------------------------------------
Commit 8ff71d61e53fbb2690f8e5a60002f108a5f17430 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8ff71d61e ]
IMPALA-14715: Fix CMake AVX2 check
Impala currently has two different checks for AVX2 compiler
support: one in be/src/util and another from Kudu in be/src/kudu/util.
The Kudu one is currently broken for the Impala build, disabling AVX2
support for blocked bloom filters. This seems to be specific to Impala's
toolchain CMake 3.22.2. Other versions of CMake (e.g. 3.22.1 on Ubuntu 22
or 3.31.10) work properly.
This centralizes the AVX2 check and uses the working version from
be/src/util. To prevent future issues, it fails the build if AVX2
support is not detected on x86_64. In order to be easy to backport,
this does not upgrade CMake (but that will happen separately).
Testing:
- Ran build on my local x86_64 machine and verified the compilation
flags for Impala's parquet bloom filters, Kudu's block bloom filters,
and roaring bitmap all reflect AVX2 support.
Change-Id: If34820a1a0d70e54df0859ec6d524b178367db0a
Reviewed-on: http://gerrit.cloudera.org:8080/23931
Reviewed-by: Jason Fehr <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> AVX2 detection in be/src/kudu/util is broken
> --------------------------------------------
>
> Key: IMPALA-14715
> URL: https://issues.apache.org/jira/browse/IMPALA-14715
> Project: IMPALA
> Issue Type: Bug
> Components: Backend, Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Blocker
> Fix For: Impala 5.0.0
>
>
> On x86_64, we're seeing that AVX2 is not being detected even though the
> system supports it:
> {noformat}
> 2026-01-30 12:38:12 - INFO-root::util|421:: Compiler does not support
> AVX2{noformat}
> This is happening for the be/src/kudu/util detection
> ([https://github.com/apache/impala/blob/6a0eedf4af137828257529501ace360208af0a3c/be/src/kudu/util/CMakeLists.txt#L293-L300]
> ), but it is not happening for the be/src/util detection
> ([https://github.com/apache/impala/blob/6a0eedf4af137828257529501ace360208af0a3c/be/src/util/CMakeLists.txt#L125-L131]
> ). It looks like this changed when we rebased Kudu.
> Kudu's check seems to work in their project, but not for us. It's unclear
> what is different.
> This disables AVX2 support for block bloom filters, costing us performance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
