[
https://issues.apache.org/jira/browse/IMPALA-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059859#comment-18059859
]
Joe McDonnell commented on IMPALA-13190:
----------------------------------------
We patched the native-toolchain here:
{noformat}
commit 51aac190369b543daddff2c0f29f54ded149a5f9
Author: Zoltan Borok-Nagy <[email protected]>
Date: Fri Jun 28 16:39:42 2024 +0200 IMPALA-13190: Allow passing const
_Atomic(T)* to LOAD operations
There was an overlook in the C11 standard that didn't allow const
argument for atomic_load operations. It was later revised,
see https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1807.htm
Since then GCC/Clang allow passing const _Atomic(T)* in all
versions of C.
LLVM discussion thread:
https://lists.llvm.org/pipermail/cfe-dev/2018-May/058129.html
Clang fix:
https://github.com/llvm/llvm-project/commit/b4b1f59869b1045258787f5a138f9710859cfe95
Change-Id: I2e257a41963dca777e1153b7153f56765a06075f
Reviewed-on: http://gerrit.cloudera.org:8080/21562
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Zoltan Borok-Nagy <[email protected]>
{noformat}
> Backport Clang compiler fix to Toolchain Clang 5.0.1
> ----------------------------------------------------
>
> Key: IMPALA-13190
> URL: https://issues.apache.org/jira/browse/IMPALA-13190
> Project: IMPALA
> Issue Type: Sub-task
> Components: Toolchain
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
>
> Toolchain Clang 5.0.1 fails to compile the CRoaring library.
> There was an overlook in the C11 standard that didn't allow const argument
> for atomic_load operations. It was later revised, see
> [https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1807.htm]
> Since then GCC/Clang allow passing const _Atomic(T)* in all versions of C.
> * LLVM discussion thread:
> [https://lists.llvm.org/pipermail/cfe-dev/2018-May/058129.html]
> * Clang fix:
> [https://github.com/llvm/llvm-project/commit/b4b1f59869b1045258787f5a138f9710859cfe95]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
