[
https://issues.apache.org/jira/browse/IMPALA-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061185#comment-18061185
]
Joe McDonnell commented on IMPALA-14607:
----------------------------------------
Patched gcc in the toolchain here:
{noformat}
commit 65bcf0ca99082360dffe1484425ec9a77e1212ca
Author: Joe McDonnell <[email protected]>
Date: Sat Feb 21 13:08:19 2026 -0800 IMPALA-14607: Patch GCC to fix Clang
variant compilation issue
Paimon support for Impala (IMPALA-14092) uses Arrow. Clang 5
is not able to build the code that uses std::variant. The
original Impala change applied a patch to libstdc++'s variant
header at build time to fix Clang compilation. This applies the
same patch during the toolchain build to simplify the fix. This
does not change the version number for GCC, so only new toolchains
will see the modification.
Testing:
- Verified that the variant header is now identical to the
version after Impala has patched it
Change-Id: I52ff4c9b9449d729febfb3260c89df78f82ba086
Reviewed-on: http://gerrit.cloudera.org:8080/24020
Reviewed-by: Joe McDonnell <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
{noformat}
At some point, we can cleanup the code in the Impala repo that does the
patching.
> Cleanup Arrow variant patch
> ---------------------------
>
> Key: IMPALA-14607
> URL: https://issues.apache.org/jira/browse/IMPALA-14607
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Riza Suminto
> Priority: Major
>
> IMPALA-14092 implement Paimon scanner node using Arrow library. But in order
> to make it work, a manual variant patching must be done.
> [https://gerrit.cloudera.org/c/23613/14/be/src/exec/paimon/CMakeLists.txt]
> We can remove it if we upgrade to a newer Clang for ASAN/TSAN/etc. We could
> also patch GCC during toolchain build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
