[
https://issues.apache.org/jira/browse/IMPALA-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069024#comment-18069024
]
ASF subversion and git services commented on IMPALA-14432:
----------------------------------------------------------
Commit b8dbc492a231fc0c995170e12ccd3a4bf4a93b24 in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b8dbc492a ]
IMPALA-14432: Upgrade Calcite version to v1.41
The following changes were needed to upgrade Calcite to v1.41:
- pom.xml file change
- Changed ImpalaConformance to derive from SqlAbstractConformance
which will automatically derive defaults for any new methods
in the class
- Handled a Calcite fix for coercing types across Union inputs.
Calcite can add a cast to a char literal to make it a different
size char literal, whereas Impala needs these literals to be
of type string.
- moved flatten code to only happen once and only happen within filter
creation (which is where the exception was thrown that it needed a
flattend RexNode).
- handled a problem where operator lists were greater than one and
the opname was not simple. This isn't used by Impala, so it is
basically ignored.
- added new default shuttle methods.
- removed a char/string conversion hack that was no longer needed.
- fixed a compatibility problem to ensure nullability for RelDataTypes
are equivalent.
- fixed a regression for the 'like' operator in 1.41. The Calcite jira
associated with this is CALCITE-7287 which has been fixed in 1.42. The
code needed to work around this regression is in RexCallConverter and
can be removed when Calcite 1.42 is released.
- The NumericLiteral toString() method returns "toPlainString()" now, which
seems to make sense anyway. The reason this change was needed for Calcite
was due to CALCITE-2067. The Literal within Calcite is still the same value
when created from a double, but the BigDecimal toString returns it in
exponent notation. This change only applies to values between 1.0 x 10^-8
and 1.0 x 10^8.
- Some of the tpcds queries have an added cast (e.g. tpcds-q1, there is a
cast around the right side of the "<" operator to DECIMAL(38, 2). This was
due to a fix in 1.38, CALCITE-6617. With that fix, the left and right sides
of the "<" operator now have an equivalent precision and scale.
Change-Id: I0fde6381c04958d69f1bee13864c11c7cd385d29
Reviewed-on: http://gerrit.cloudera.org:8080/24043
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Upgrade Calcite to v1.40
> ------------------------
>
> Key: IMPALA-14432
> URL: https://issues.apache.org/jira/browse/IMPALA-14432
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Steve Carlin
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
