[
https://issues.apache.org/jira/browse/IMPALA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084116#comment-18084116
]
Aleksandr Efimov commented on IMPALA-14838:
-------------------------------------------
I picked this up and posted a patch for review:
https://gerrit.cloudera.org/c/Impala-ASF/+/24375
The patch makes TotalHasDeferredRPCsTime include currently open
deferred-RPC intervals by exposing it as a derived counter. It also adds
a regression test that samples the profile while the deferred RPC queue
is still non-empty.
Validation:
- ./buildall.sh -skiptests -noclean -ninja
- be/build/latest/runtime/data-stream-test
--gtest_filter=DataStreamTest.TotalHasDeferredRpcsTimeIncludesOpenInterval
- be/build/latest/runtime/data-stream-test
> TotalHasDeferredRPCsTime is not set if deferred_rpcs_ is never empty
> ---------------------------------------------------------------------
>
> Key: IMPALA-14838
> URL: https://issues.apache.org/jira/browse/IMPALA-14838
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Aleksandr Efimov
> Priority: Major
> Labels: ramp-up
>
> Saw these conflicting counters in a cancelled profile:
> - TotalHasDeferredRPCsTime: 0.000ns
> - TotalRPCsDeferred: 1.36K (1364)
> The issue is that TotalHasDeferredRPCsTime is only increased when the queue
> gets empty so will be 0 if the query is cancelled while the queue was never
> depleted:
> https://github.com/apache/impala/blob/ef2d50e68987ccbf713122b8f301709a874c5121/be/src/runtime/krpc-data-stream-recvr.cc#L339
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
