[
https://issues.apache.org/jira/browse/IMPALA-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084291#comment-18084291
]
ASF subversion and git services commented on IMPALA-13033:
----------------------------------------------------------
Commit b8be5139965703e2864ff74be1d6b14a253ac4df in impala's branch
refs/heads/master from Aleksandr Efimov
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b8be51399 ]
IMPALA-13033: Parse WebUI thrift profile downloads
WebUI thrift profile downloads contain the archived profile string
without the timestamp and query id prefix used by profile log lines.
impala-profile-tool currently treats these files as malformed input.
Retry failed log-line parses as bare archived profile input while
keeping query id and timestamp filters limited to log entries that
include metadata. Add regression coverage for bare profile input using
the existing public profile fixtures.
Generated-by: OpenAI Codex
Change-Id: I2baed77cce3de43ef153b853329ad899f999f473
Reviewed-on: http://gerrit.cloudera.org:8080/24357
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> impala-profile-tool should support parsing thrift profiles downloaded from
> WebUI
> --------------------------------------------------------------------------------
>
> Key: IMPALA-13033
> URL: https://issues.apache.org/jira/browse/IMPALA-13033
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Reporter: Quanlong Huang
> Assignee: Aleksandr Efimov
> Priority: Major
> Labels: newbie, ramp-up
> Attachments: impala_profile_log_1.1-1739386192341,
> thrift_profile_a24f644ffd56a8ad_7011d75300000000.txt
>
>
> In the coordinator WebUI, users can download query profiles in
> text/json/thrift formats. The thrift profile is the same as one line in the
> profile log without the timestamp and query id at the beginning.
> impala-profile-tool fails to parse such a file. It should retry parsing the
> whole line as the encoded profile. Current code snipper:
> {code:cpp}
> // Parse out fields from the line.
> istringstream liness(line);
> int64_t timestamp;
> string query_id, encoded_profile;
> liness >> timestamp >> query_id >> encoded_profile;
> if (liness.fail()) {
> cerr << "Error parsing line " << lineno << ": '" << line << "'\n";
> ++errors;
> continue;
> }{code}
> https://github.com/apache/impala/blob/f620e5d5c0bbdb0fd97bac31c7b7439cd13c6d08/be/src/util/impala-profile-tool.cc#L109
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
