[
https://issues.apache.org/jira/browse/IMPALA-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085560#comment-18085560
]
ASF subversion and git services commented on IMPALA-14782:
----------------------------------------------------------
Commit 70bdb09a819e315a040fe6ff9b3ec9e762f440d5 in impala's branch
refs/heads/master from Mihaly Szjatinya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=70bdb09a8 ]
IMPALA-14782: Use CatalogUtil instead of Catalogs
This change gets rid of iceberg-mr dependency by calling the Iceberg's
CatalogUtil and *Catalog methods directly. Also some constants were
replaced. The former wrapper class IcebergCalalogs is now renamed to
IcebergCatalogUtil.
Most of the logic from Catalogs is preserved, except for
'iceberg.catalog.location_based_table' being resolved to HadoopTable
catalog.
Note: renameTable, which was unsupported for Catalogs, is now calling
the underlying catalog's renameTable() directly, same as other
functions. For HadoopTable however it's still an unsupported operation,
but the error we're getting is more precise.
Testing:
- Ran following tests involving IcebergCatalogs:
test_iceberg.py::TestIcebergTable::test_catalogs
test_iceberg.py::TestIcebergTable::test_expire_snapshots
test_iceberg.py::TestIcebergTable::test_execute_rollback
test_events_custom_configs.py::TestEventProcessingCustomConfigs \
::test_iceberg_self_events
Change-Id: Ica56a3223e9d6fa08a6cec52b8c8d8869afa8ca5
Reviewed-on: http://gerrit.cloudera.org:8080/24369
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Use CatalogUtil instead of Catalogs
> -----------------------------------
>
> Key: IMPALA-14782
> URL: https://issues.apache.org/jira/browse/IMPALA-14782
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Zoltán Borók-Nagy
> Priority: Major
> Labels: impala-iceberg
>
> Catalogs [1] is the only reason we depend on iceberg-mr. And the Iceberg
> community wants to deprecate it.
> CatalogUtil [2] has all the functionality we need. Only limitation is that it
> doesn't support HadoopTables, but they are supported natively by Impala
> anyway.
> [1][https://github.com/apache/iceberg/blob/main/mr/src/main/java/org/apache/iceberg/mr/Catalogs.java]
> [2]
> [https://github.com/apache/iceberg/blob/d2fbe427ecec298f1600260f40fcab1b7ab2e695/core/src/main/java/org/apache/iceberg/CatalogUtil.java]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
