[
https://issues.apache.org/jira/browse/IMPALA-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085742#comment-18085742
]
Csaba Ringhofer commented on IMPALA-15060:
------------------------------------------
There was some discussion about how to proceed with CatalogServiceVersion. I
think that the mechanism of using a single integer version is not robust enough
- some commits that broke interface didn't bump it and it is not suitable for
backports (for example change A bumps 2->3, change B bumps 3-4 - what should be
the version on a branch that backports B, but not A?). It would be great to
handle Impala's internal interfaces as proper APIs with backward compatibility,
but would need additional effort, especially to actually test cross version
scenarios.
My preference would be to bump to version 3 in a separate commit that also adds
a new mechanism to send the build's git hash and reject communication if the
hashes do not match. This would deny any cross version communication, which is
the safest solution at the moment IMO.
I would do the same for StatestoreServiceVersion - this would transitively deny
communication between impalads of different version, as coordinators get the
list of executors from statestore, so for a coordinator to see an executor the
following needs to be true: coordinator_hash == statestore_hash and
statestore_hash == executor_hash.
> Bump CatalogServiceVersion
> --------------------------
>
> Key: IMPALA-15060
> URL: https://issues.apache.org/jira/browse/IMPALA-15060
> Project: IMPALA
> Issue Type: Task
> Components: Catalog
> Reporter: Noémi Pap-Takács
> Assignee: Noémi Pap-Takács
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> Currently we are on V2 Catalog version. Since then, many features caused
> breaking changes to the Thrift interface in the communication between the
> Catalog and the Coordinator, either on semantic level or wire-level.
> We should mark these changes by incrementing the CatalogServiceVersion in
> CatalogService.thrift.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
