[
https://issues.apache.org/jira/browse/IMPALA-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087071#comment-18087071
]
Aleksandr Efimov commented on IMPALA-15081:
-------------------------------------------
Posted an initial patch for this improvement:
http://gerrit.cloudera.org:8080/24417
The change documents the Unix epoch milliseconds semantics for
--min_timestamp/--max_timestamp and improves the error message when a
profile-log timestamp cannot be parsed while timestamp filtering is enabled.
> Improve impala-profile-tool timestamp filter handling
> -----------------------------------------------------
>
> Key: IMPALA-15081
> URL: https://issues.apache.org/jira/browse/IMPALA-15081
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Aleksandr Efimov
> Assignee: Aleksandr Efimov
> Priority: Minor
>
> impala-profile-tool supports --min_timestamp and --max_timestamp for filtering
> profile log entries by the timestamp prefix. The current upstream profile log
> writer prefixes entries with UnixMillis(), but the tool help only describes
> the
> filter value as an "integer timestamp" and parse errors do not explain the
> expected unit.
> IMPALA-14099 also surfaced a profile-log-like entry with an oversized,
> non-canonical timestamp token. The immediate fix for IMPALA-14099
> intentionally
> keeps the existing int64 timestamp-filter behavior and only avoids rejecting
> the
> profile payload when timestamp filters are not requested.
> This follow-up tracks making timestamp handling clearer and more useful.
> Proposed scope:
> - Document that --min_timestamp and --max_timestamp expect Unix epoch
> milliseconds.
> - Improve diagnostics when timestamp filters are requested but an entry's
> timestamp token is invalid or out of range.
> - Investigate where high-precision or non-canonical timestamp tokens like the
> one from IMPALA-14099 come from.
> - Consider adding human-readable filters such as --min_time/--max_time with
> ISO-8601 UTC input.
> - If real profile logs use microsecond or nanosecond epoch timestamps,
> consider
> explicit timestamp unit handling rather than silently guessing units.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
