[
https://issues.apache.org/jira/browse/IMPALA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088565#comment-18088565
]
Aleksandr Efimov commented on IMPALA-15096:
-------------------------------------------
Uploaded a patch for this: http://gerrit.cloudera.org:8080/24453
The fix renders raw_text.tmpl contents unescaped only when the handler sets
Webserver::ENABLE_RAW_HTML_KEY. This fixes downloaded plain-text profiles while
preserving escaped output for non-raw users of the same template.
Validation:
- Verified that html.unescape(rf_profile_web.txt) matches rf_profile.txt from
the attachments.
- Added focused webserver regression tests for raw and non-raw raw_text.tmpl
rendering.
- Ran critique-gerrit-review.py --dryrun.
- Ran the focused webserver-test.
> Text profiles downloaded from WebUI have HTML entities
> ------------------------------------------------------
>
> Key: IMPALA-15096
> URL: https://issues.apache.org/jira/browse/IMPALA-15096
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Aleksandr Efimov
> Priority: Major
> Attachments: rf_profile.txt, rf_profile_web.txt
>
>
> Text profiles downloaded from WebUI have HTML entities like "'",
> "<", ">". These impact readability. We should convert them to
> the actual characters in the downloaded profile.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
