[
https://issues.apache.org/jira/browse/IMPALA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089439#comment-18089439
]
ASF subversion and git services commented on IMPALA-15105:
----------------------------------------------------------
Commit d4aa2350b37faf77bf8dc910cd070562499fb8ab in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d4aa2350b ]
IMPALA-15105: Don't package test configuration files in calcite-planner
The calcite-planner module declares fe/src/test/resources as a maven
resource directory, which causes all configuration files (e.g.,
hive-site.xml) for testing are packaged into the jar file. They could be
used in production, which overwrites the real configuration files.
This patch removes it and modifies TpcdsCpuCostPlannerTest to copy the
configuration files in classpath directories, so don't need them in the
jar file.
Testing
- Ran Java unitests in calcite-planner.
Assisted-by: Opus 4.8 (Cursor)
Change-Id: I2780ad8fc9d0c8b9f1a1962dc0f9eb7d167b1783
Reviewed-on: http://gerrit.cloudera.org:8080/24473
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> calcite-planner shouldn't package test configuration files
> ----------------------------------------------------------
>
> Key: IMPALA-15105
> URL: https://issues.apache.org/jira/browse/IMPALA-15105
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> While modifying fe/src/test/resources/hive-site.xml for local testing, I
> found it's not used by Impala. Instead, the one in the calcite-planner jar is
> picked up:
> {code:java}
> I20260616 09:33:06.919615 419080 MetastoreConf.java:2165] Found configuration
> file
> jar:file:/home/quanlong/workspace/Impala/java/calcite-planner/target/calcite-planner-5.0.0-SNAPSHOT.jar!/hive-site.xml{code}
> Packaging these configuration files in the calcite-planner jar file will
> deploy them in production. They might overwrite users configurations. We
> should only use them in testing.
> CC [~scarlin]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
