[
https://issues.apache.org/jira/browse/IMPALA-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090355#comment-18090355
]
ASF subversion and git services commented on IMPALA-15079:
----------------------------------------------------------
Commit dc6a7d4a7a761df102cf1d5df5a99b87774d3155 in impala's branch
refs/heads/master from Noemi Pap-Takacs
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=dc6a7d4a7 ]
IMPALA-15079: Cleanup Open/Close locking in SharedJdbcConnection
Changes:
- simplified Open() logic which waited on condition_variable
without any benefit
- renamed open_mu_ to lock_ which is the usual name in Impala
- changed ref_count_ from atomic to simple int protected by lock_
as it is not used frequently
Change-Id: Ic9f5c4ac71031b74b51bfa27ed04be10ed92e222
Reviewed-on: http://gerrit.cloudera.org:8080/24416
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Unneeded condition variable open_cv_ in SharedJdbcConnection
> ------------------------------------------------------------
>
> Key: IMPALA-15079
> URL: https://issues.apache.org/jira/browse/IMPALA-15079
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Major
>
> The goal of open_cv_ seems to be to wait here:
> https://github.com/apache/impala/blame/2be15d0d9f1d0be64428f3b4f4dd1569dd37782c/be/src/exec/data-source-scan-node.cc#L121
> but at this point open_done_ must be already true as the whole initialization
> is guarded by a lock
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
