[
https://issues.apache.org/jira/browse/IMPALA-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092821#comment-18092821
]
ASF subversion and git services commented on IMPALA-14849:
----------------------------------------------------------
Commit 37056e7e39f1d6d1db8434c1695b0ccd777846fd in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=37056e7e3 ]
IMPALA-14849: Upgrade Calcite planner to 1.42
Upgraded to Calcite 1.42.
Some problems addressed:
- getMaxNumPrecision and getMaxNumScale were made final methods in
Calcite causing a compilation error.
- A Jira fix changed the interval expression to use CHECKED_TIMES
rather than TIMES for the operator.
- The avatica dependency is not needed.
- 1.42 added new support for some correlated queries which now compile
in Calcite and will no longer fallback to the original planner.
- The support of some new correlated queries uncovered some incorrect
results which can be found in subquery.test and grouping-sets.test.
IMPALA-15122 and IMPALA-15124 have been filed to deal with these
incorrect results in the original planner.
- Some tests for spilling had to be commented out. The queries in the
file used to fallback to the original planner. They succeed now. But
the plans generated are different. The original planner produces
anti-join queries and the Calcite planner does not. This results in
different memory usage. The spilling tests are specifically designed
to handle this. IMPALA-15123has been filed to ensure these tests
will eventually work for the Calcite planner.
- This is a small performance regression in
analytic-rank-pushdown-calcite.test. IMPALA-15125 has been filed. A
Filter/Values RelNode is not being reduced. This will have a minimal
performance impact, so it should be ok to do the upgrade with this
issue.
Change-Id: I4bfb3271282f3dfdd250fa61bce1492e5dd499f8
Reviewed-on: http://gerrit.cloudera.org:8080/24261
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Aman Sinha <[email protected]>
> Upgrade to Calcite 1.42
> -----------------------
>
> Key: IMPALA-14849
> URL: https://issues.apache.org/jira/browse/IMPALA-14849
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Steve Carlin
> Priority: Major
>
> Upgrade to Calcite 1.42 when it is released.
> Note: There is some code in RexCallConverter.java that can be removed when
> the upgrade is done, which was fixed with CALCITE-7287. There is a long
> comment there describing what was done.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
