[ 
https://issues.apache.org/jira/browse/IMPALA-15131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093412#comment-18093412
 ] 

ASF subversion and git services commented on IMPALA-15131:
----------------------------------------------------------

Commit 21f79c520af843bb18103c70ee8e147a237d5ef0 in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=21f79c520 ]

IMPALA-15131: Simplify file format handling in hdfs-scan-node

Old code selected file format for Iceberg and Hive
tables differently (per file vs per partition).
This can be simplifed as HdfsFileDesc has the
file format set at this point.

Assisted-by: Claude Opus 4.8

Change-Id: I82f84d17e67cb0bb6dbba2ea86b602290d96de8c
Reviewed-on: http://gerrit.cloudera.org:8080/24531
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>


>  Simplify file format handling in hdfs-scan-node-base.cc
> --------------------------------------------------------
>
>                 Key: IMPALA-15131
>                 URL: https://issues.apache.org/jira/browse/IMPALA-15131
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Csaba Ringhofer
>            Priority: Minor
>
> The Iceberg vs Hive table distinction is not really needed, HdfsFileDesc 
> already has the file format set.
> https://github.com/apache/impala/blob/e47134ece299ddd2d538c9017b44b383b35e9d28/be/src/exec/hdfs-scan-node-base.cc#L917



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to