[
https://issues.apache.org/jira/browse/IMPALA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltán Borók-Nagy updated IMPALA-13913:
---------------------------------------
Target Version: (was: Impala 5.0.0)
> Replace debugging flags with debug action
> -----------------------------------------
>
> Key: IMPALA-13913
> URL: https://issues.apache.org/jira/browse/IMPALA-13913
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Riza Suminto
> Priority: Major
>
> Like IMPALA-13906, several debugging flags should be replaced into debug
> action.
> Doing so will make it possible to change custom_cluster tests associated with
> the flag into a regular e2e query_tests. The fault/slowdown injection can
> then be delivered through query option DEBUG_ACTION.
> These are some possible suspect for improvement:
> {noformat}
> $ git grep -n -A2 'ifndef NDEBUG' | grep FLAGS
> be/src/catalog/catalog-server.cc-558- if
> (FLAGS_stress_catalog_startup_delay_ms > 0) {
> be/src/catalog/catalog-server.cc-559-
> SleepForMs(FLAGS_stress_catalog_startup_delay_ms);
> be/src/exec/exchange-node.cc-97- if (FLAGS_stress_datastream_recvr_delay_ms
> > 0) {
> be/src/exec/exchange-node.cc-98-
> SleepForMs(FLAGS_stress_datastream_recvr_delay_ms);
> be/src/exec/hdfs-scan-node-base.cc-775- if
> (FLAGS_skip_file_runtime_filtering) return true;
> be/src/kudu/util/blocking_queue-test.cc-244-
> ::testing::FLAGS_gtest_death_test_style = "threadsafe";
> be/src/runtime/io/disk-io-mgr-test.cc-1542- auto s =
> ScopedFlagSetter<int32_t>::Make(&FLAGS_stress_disk_read_delay_ms, 5);
> be/src/runtime/io/disk-io-mgr-test.cc-1587- auto s =
> ScopedFlagSetter<int32_t>::Make(&FLAGS_stress_disk_read_delay_ms, 5);
> be/src/runtime/io/disk-io-mgr.cc-922- if
> (FLAGS_stress_scratch_write_delay_ms > 0) {
> be/src/runtime/io/disk-io-mgr.cc-923-
> SleepForMs(FLAGS_stress_scratch_write_delay_ms);
> be/src/runtime/io/hdfs-file-reader.cc-115- if
> (FLAGS_stress_disk_read_delay_ms > 0) {
> be/src/runtime/io/hdfs-file-reader.cc-116-
> SleepForMs(FLAGS_stress_disk_read_delay_ms);
> be/src/runtime/io/local-file-reader.cc-60- if
> (FLAGS_stress_disk_read_delay_ms > 0) {
> be/src/runtime/io/local-file-reader.cc-61-
> SleepForMs(FLAGS_stress_disk_read_delay_ms);
> be/src/runtime/query-state.cc-659- if (FLAGS_stress_status_report_delay_ms) {
> be/src/runtime/query-state.cc-660- LOG(INFO) << "Sleeping " <<
> FLAGS_stress_status_report_delay_ms << "ms before "
> be/src/runtime/tmp-file-mgr-test.cc-90-
> FLAGS_stress_scratch_write_delay_ms = 0;
> be/src/runtime/tmp-file-mgr-test.cc-728- FLAGS_stress_scratch_write_delay_ms
> = 1000;
> be/src/service/frontend.cc-381- if (FLAGS_stress_catalog_init_delay_ms > 0) {
> be/src/service/frontend.cc-382-
> SleepForMs(FLAGS_stress_catalog_init_delay_ms);
> be/src/statestore/statestore.cc-778- if
> (FLAGS_stress_statestore_startup_delay_ms > 0) {
> be/src/util/thread.cc-304- if (fault_injection_eligible &&
> FLAGS_thread_creation_fault_injection) {{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
