[ 
https://issues.apache.org/jira/browse/IMPALA-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095084#comment-18095084
 ] 

Michael Smith commented on IMPALA-12522:
----------------------------------------

I just saw a case with {{enable_async_ddl_execution=True}} as well:
{code}
/data/jenkins/workspace/impala-cdh_main-core/repos/Impala/tests/metadata/test_ddl.py:1188:
 in test_alter_table_recover
    assert(wait_time >= 10)
E   assert 9.984899759292603 >= 10
        alltypes_location = '/test-warehouse/alltypes_parquet'
        alter_stmt = 'alter table 
test_alter_table_recover_f9d48c2c.alltypes_clone recover partitions'
        client     = <tests.common.impala_connection.ImpylaHS2Connection object 
at 0x7f5dae97e9d0>
        create_table_stmt = 'create external table 
test_alter_table_recover_f9d48c2c.alltypes_clone like 
functional_parquet.alltypes location "/test-warehouse/alltypes_parquet"'
        dest_tbl   = 'test_alter_table_recover_f9d48c2c.alltypes_clone'
        enable_async_ddl = True
        exec_end   = 1783575346.562828
        exec_start = 1783575346.2517195
        exec_time  = 0.3111085891723633
        handle     = <tests.common.impala_connection.OperationHandle object at 
0x7f5dae901e10>
        new_vector = "table_format: text/none" | "protocol: hs2-http" | 
"enable_async_ddl_execution: True" | "exec_option: {'abort_on_error... 
'test_replan': 1, 'enable_async_ddl_execution': True, 'debug_action': 
'CRS_DELAY_BEFORE_CATALOG_OP_EXEC:SLEEP@10000'}"
        self       = <tests.metadata.test_ddl.TestAsyncDDLTiming object at 
0x7f5dae92ec10>
        source_tbl = 'functional_parquet.alltypes'
        state      = 'RUNNING'
        unique_database = 'test_alter_table_recover_f9d48c2c'
        vector     = "table_format: text/none" | "protocol: hs2-http" | 
"enable_async_ddl_execution: True" | "exec_option: 
{'abort_on_error...ble_codegen_rows_threshold': 0, 
'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'sync_ddl': 0, 
'test_replan': 1}"
        wait_end   = 1783575356.5827734
        wait_start = 1783575346.5978737
        wait_time  = 9.984899759292603
{code}

> test_alter_table_recover could finish less than 10 seconds with JDK 17 when 
> enable_async_ddl_execution is False
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-12522
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12522
>             Project: IMPALA
>          Issue Type: Test
>            Reporter: Fang-Yu Rao
>            Assignee: Joe McDonnell
>            Priority: Critical
>              Labels: broken-build, flaky-test
>
> We found that 
> [test_alter_table_recover()|https://github.com/apache/impala/blame/master/tests/metadata/test_ddl.py#L1026]
>  could finish the execution within 10 seconds with JDK 17 when 
> enable_async_ddl_execution is False and thus the check in the [else 
> branch|https://github.com/apache/impala/blame/master/tests/metadata/test_ddl.py#L1079C12-L1079C12]
>  could fail. Don't know it has something to do with JDK but maybe we could 
> reduce the expected execution time a little bit to make the test less flaky.
> {code}
>       # In sync mode:
>       #  The entire DDL is processed in the exec step with delay. exec_time 
> should be
>       #  more than 10 seconds.
>       #
>       # In async mode:
>       #  The compilation of DDL is processed in the exec step without delay. 
> And the
>       #  processing of the DDL plan is in wait step with delay. The wait time 
> should
>       #  definitely take more time than 10 seconds.
>       if enable_async_ddl:
>         assert(wait_time >= 10)
>       else:
>         assert(exec_time >= 10)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to