[
https://issues.apache.org/jira/browse/IMPALA-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098590#comment-18098590
]
ASF subversion and git services commented on IMPALA-5924:
---------------------------------------------------------
Commit df496831fdc845eb87cbffc25b806a2570ee40f7 in impala's branch
refs/heads/master from Gowthami Bisati
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=df496831f ]
IMPALA-5924: Formatting TBLPROPERTIES in SHOW CREATE TABLE
When we run SHOW CREATE TABLE via Impala-shell output displays the
TBLPROPERTIES in a single line which makes it difficult to read
through all the properties.
Change:
Modified ToSqlUtils.java to wrap reconstructed TBLPROPERTIES into a
clean multi-line, indented layout instead of outputting them as a
single dense line.
Modified ToSqlTest.java to update the expected string assertions to
match the new multi-line format.
Modified test_kudu.py and LocalCatalogTest.java to match the expected DDL
output.
Example:
Before this change, TBLPROPERTIES were formatted on a single line in
SHOW CREATE TABLE output:
TBLPROPERTIES ('OBJCAPABILITIES'='HIVEMANAGEDINSERTREAD...', ...)
After this change, they are cleanly wrapped:
TBLPROPERTIES (
'OBJCAPABILITIES'='EXTREAD,EXTWRITE',
'TRANSLATED_TO_EXTERNAL'='TRUE',
'external.table.purge'='TRUE'
)
This improves the readability of generated DDL statements when
executing SHOW CREATE TABLE or viewing view definitions via
impala-shell.
Testing Performed:
- Updated expected string outputs in ToSqlTest.java to account for the
new whitespace layouts.
- Verified frontend changes compile cleanly using checkstyle.
- Ran mvn clean package -DskipTests (BUILD SUCCESS).
- Ran focus testing suite: mvn test -Dtest=ToSqlTest
(BUILD SUCCESS).
- Ran idempotency integrity validation suite:
mvn test -Dtest=ToSqlUtilsTest (BUILD SUCCESS).
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
- tests/run-tests.py query_test/test_kudu.py
- mvn -Dtest=LocalCatalogTest#testHbaseTable test
- This change will list the TBLPROPERTIES for Hbase tables as well.
- bin/impala-py.test --exploration_strategy=exhaustive\
tests/custom_cluster/test_workload_mgmt_init.py
Change-Id: Ic198d0a42cf3636fe612460c12d8c8000a313ef1
Signed-off-by: Gowthami Bisati <[email protected]>
Reviewed-on: http://gerrit.cloudera.org:8080/24554
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Show CREATE TABLE output vertically
> -----------------------------------
>
> Key: IMPALA-5924
> URL: https://issues.apache.org/jira/browse/IMPALA-5924
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: Abhishek Talluri
> Assignee: Gowthami Bisati
> Priority: Major
> Labels: newbie
> Attachments: hue.png, impala_shell.png
>
>
> When we do a show create table in Impala, it lists out the create table
> statement horizontally which makes it difficult for developers to debug and
> see what is used as filter conditions or what is the storage format used and
> other things. The view is vertical in Hive but not in Impala.
> One more improvement can be to minimize the column names with a (+) and then
> just show the table name and all other properties. If the user tries to see
> the columns, then he can click the (+) sign to list the columns in that table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
