[
https://issues.apache.org/jira/browse/IMPALA-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098611#comment-18098611
]
ASF subversion and git services commented on IMPALA-15206:
----------------------------------------------------------
Commit 1c7047bd387aa221c05a43413cc98bb2a91c83af in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1c7047bd3 ]
IMPALA-15206: Skip coverage directory for test_no_unsupported_operations
On code coverage builds, the frontend test coverage output includes
Java code. Some Java files reference CannotAccessFieldException, so
that trips up TestBannedLogMessages::test_no_unsupported_operations().
This changes test_no_unsupported_operations() to exclude the coverage
directory.
Testing:
- Ran CatalogdMetaProviderTest with code coverage, then ran
test_banned_log_messages.py. This failed consistently before
this change and now passes.
Change-Id: I91ab869e3b1bf1e84a91bbdfd62d9b6d95b5db96
Reviewed-on: http://gerrit.cloudera.org:8080/24624
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestBannedLogMessages.test_no_unsupported_operations fails on coverage runs
> ---------------------------------------------------------------------------
>
> Key: IMPALA-15206
> URL: https://issues.apache.org/jira/browse/IMPALA-15206
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Critical
> Labels: broken-build
>
> Coverage exhaustive test jobs are consistently hitting this error:
> {noformat}
> verifiers/test_banned_log_messages.py:48: in test_no_unsupported_operations
> self.assert_message_absent('CannotAccessFieldException')
> self =
> <tests.verifiers.test_banned_log_messages.TestBannedLogMessages object at
> 0x7f3947b8e6d0>
> verifiers/test_banned_log_messages.py:40: in assert_message_absent
> assert returncode == 1, "%s contains '%s'" % (log_file_path, message)
> E AssertionError:
> /data/jenkins/workspace/impala-cdh_main-exhaustive-coverage/repos/Impala/logs/fe_tests/coverage/org.apache.impala.catalog.local/CatalogdMetaProvider.java.html
> contains 'CannotAccessFieldException'
> E assert 0 == 1
> E +0
> E -1
> dirs = []
> file = 'CatalogdMetaProvider.java.html'
> files = ['LocalDb.java.html',
> 'InconsistentMetadataFetchException.java.html',
> 'LocalDataSourceTable.java.html', 'LocalTable.java.html',
> 'MetaProvider.java.html', 'DirectMetaProvider.java.html', ...]
> log_dir =
> '/data/jenkins/workspace/impala-cdh_main-exhaustive-coverage/repos/Impala/logs'
> log_file_path =
> '/data/jenkins/workspace/impala-cdh_main-exhaustive-coverage/repos/Impala/logs/fe_tests/coverage/org.apache.impala.catalog.local/CatalogdMetaProvider.java.html'
> message = 'CannotAccessFieldException'
> returncode = 0
> root =
> '/data/jenkins/workspace/impala-cdh_main-exhaustive-coverage/repos/Impala/logs/fe_tests/coverage/org.apache.impala.catalog.local'
> self =
> <tests.verifiers.test_banned_log_messages.TestBannedLogMessages object at
> 0x7f3947b8e6d0>
> skip_subdirs = None{noformat}
> The frontend coverage HTML files in fe_test/coverage include the Java source
> code, which has references to CannotAccessFieldException. We should change
> the test to avoid matching these files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
