[
https://issues.apache.org/jira/browse/IMPALA-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18104209#comment-18104209
]
ASF subversion and git services commented on IMPALA-15028:
----------------------------------------------------------
Commit 49c867d40f291bcf88757d9a410d0b7aa29f98e3 in impala's branch
refs/heads/master from Anubhav Jindal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=49c867d40 ]
IMPALA-15028: Add Helm chart render assertions
Add a lightweight CI-friendly chart test harness that runs helm lint,
renders default and override manifests, and asserts key Impala Helm
chart behaviors to prevent regressions.
Wire chart checks into bin/run-all-tests.sh as an opt-in stage
(HELM_CHART_TEST=false by default) and keep Jenkins all-tests behavior
unchanged unless explicitly enabled.
Cover both core defaults and optional chart functionality, including
LDAP, Ranger, Kudu, OAuth, and secure-cluster Kerberos/TLS/Istio paths.
Also validate required-value failures for secure secret inputs.
Align assert script execution with repository conventions by using an
executable shebang (#!/usr/bin/env impala-python3), invoking the script
directly, and documenting required local dependencies.
Testing:
- bash -n bin/jenkins/all-tests.sh
- bash -n bin/run-all-tests.sh
- bash -n helm/impala/tests/run-chart-tests.sh
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8
Assisted-by: GPT-5.3 (Cursor)
Reviewed-on: http://gerrit.cloudera.org:8080/24368
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>
> Add automated tests for Impala Helm chart configuration defaults
> ----------------------------------------------------------------
>
> Key: IMPALA-15028
> URL: https://issues.apache.org/jira/browse/IMPALA-15028
> Project: IMPALA
> Issue Type: Task
> Reporter: Anubhav Jindal
> Assignee: Anubhav Jindal
> Priority: Major
>
> *Problem*
> The new Impala Helm chart currently relies on manual validation for several
> key behaviors (for example image defaults, port exposure, and config-driven
> daemon flags). We need automated coverage to prevent regressions and to make
> review/verification repeatable.
> *Proposed Change*
> Add automated tests for the Helm chart that validate rendered manifests and
> key runtime-oriented configuration behavior.
> Initial coverage should include:
> * Default image prefix renders {{apache/impala:4.5.0-...}} component images.
> * Deprecated Beeswax port is not exposed in {{impalad}} deployment/service.
> * {{{}catalogd.v{}}}, {{{}impalad.v{}}}, and {{statestored.v}} values
> correctly render daemon {{-v}} args (default {{{}1{}}}, overrideable).
> * {{catalogd.hmsEventPollingIntervalS}} is rendered correctly, including
> compatibility value {{{}0{}}}.
> * {{hms.securityContext}} values (e.g. {{{}runAsUser{}}},
> {{{}runAsGroup{}}}) render correctly when set.
> * Chart lint/template checks are exercised in CI-friendly scripts.
> Implementation can use a lightweight chart test framework (or script-based
> golden checks) that runs with {{helm lint}} + {{helm template}} assertions.
> *Testing*
> * Add automated test cases for default and override values.
> * Verify tests fail on intentional regressions (e.g., reintroducing Beeswax
> port).
> * Run tests in local/dev CI environment and include invocation steps in docs.
> *Compatibility / Risk*
> Low risk. This change adds test coverage only and does not alter runtime
> behavior of existing chart defaults.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
