[ 
https://issues.apache.org/jira/browse/IMPALA-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118943#comment-18118943
 ] 

ASF subversion and git services commented on IMPALA-15416:
----------------------------------------------------------

Commit e99a13c1c575fd39594dc0c91251f97650c46130 in impala's branch 
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e99a13c1c ]

IMPALA-15416: Fix compound predicate push-down test for Calcite

TestIcebergTable.test_compound_predicate_push_down failed in the
Calcite planner build with an unexpected NumRowGroups value (10
instead of 12) for the query with the following predicate:

  not (col_bi + 1 != 123 or col_db = 2.71822 or col_i = -1)

The legacy planner cannot push this predicate down to Iceberg, as
'col_bi + 1 != 123' cannot be converted to an Iceberg expression.
Calcite pushes the NOT into the OR, so the predicates become
separate conjuncts, and 'NOT col_db = 2.71822' is pushed down to
Iceberg. Since the Iceberg 1.11 upgrade (IMPALA-15330) Iceberg
skips data files for NOT_EQ predicates when the lower and upper
bounds are equal to the literal, which is true for two data files.

This patch adds a CALCITE_PLANNER_RUNTIME_PROFILE section for the
query that expects 10 row groups.

Testing:
 * ran test_compound_predicate_push_down with both planners

Change-Id: Ia0ddf3dcce34d93755511d0234339b153de6b72b
Assisted-by: Claude Opus 5.5 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/24934
Reviewed-by: Peter Rozsa <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> TestIcebergTable.test_compound_predicate_push_down fails in the Calcite 
> planner build 
> --------------------------------------------------------------------------------------
>
>                 Key: IMPALA-15416
>                 URL: https://issues.apache.org/jira/browse/IMPALA-15416
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Test
>            Reporter: Peter Rozsa
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>              Labels: broken-build, impala-iceberg
>             Fix For: Impala 5.0.0
>
>
> TestIcebergTable.test_compound_predicate_push_down fails in the Calcite 
> planner.
>   AssertionError: Aggregation of SUM over NumRowGroups did not match expected 
> results.
>     EXPECTED VALUE: 12
>     ACTUAL VALUE:   10
> The query results are correct (RESULTS section matches); only the NumRowGroups
> counter in the runtime profile differs. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to